Skip to content

fix: throw error when maxError is non-positive #151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kylebarron merged 1 commit into from
Jan 3, 2026
Merged

fix: throw error when maxError is non-positive #151

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions packages/deck.gl-geotiff/src/cog-layer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,6 @@ import { epsgIoGeoKeyParser } from "./proj.js";
// https://github.com/visgl/deck.gl/pull/9917
type Tileset2DProps = any;

const DEFAULT_MAX_ERROR = 0.125;

/**
* Minimum interface that **must** be returned from getTileData.
*/
Expand Down Expand Up @@ -164,9 +162,10 @@ export interface COGLayerProps<DataT extends MinimalDataT = DefaultDataT>
}

const defaultProps: Partial<COGLayerProps> = {
maxError: DEFAULT_MAX_ERROR,
geoKeysParser: epsgIoGeoKeyParser,
getTileData: loadRgbImage,
debug: false,
debugOpacity: 0.5,
renderTile: (data) => {
return data.texture;
},
Expand Down Expand Up @@ -304,7 +303,7 @@ export class COGLayer<
forwardReproject: ReprojectionFns["forwardReproject"],
inverseReproject: ReprojectionFns["inverseReproject"],
): Layer | LayersList | null {
const { maxError, debug = false, debugOpacity = 0.5 } = this.props;
const { maxError, debug, debugOpacity } = this.props;
const { tile } = props;
const { data, forwardTransform, inverseTransform } = props.data;

Expand Down
3 changes: 0 additions & 3 deletions packages/deck.gl-geotiff/src/geotiff-layer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,6 @@ import { extractGeotiffReprojectors } from "./geotiff-reprojection.js";
import type { GeoKeysParser, ProjectionInfo } from "./proj.js";
import { epsgIoGeoKeyParser } from "./proj.js";

const DEFAULT_MAX_ERROR = 0.125;

export interface GeoTIFFLayerProps extends CompositeLayerProps {
/**
* GeoTIFF input.
Expand Down Expand Up @@ -90,7 +88,6 @@ export interface GeoTIFFLayerProps extends CompositeLayerProps {
}

const defaultProps = {
maxError: DEFAULT_MAX_ERROR,
geoKeysParser: epsgIoGeoKeyParser,
};

Expand Down
2 changes: 1 addition & 1 deletion packages/deck.gl-raster/src/raster-layer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,8 +82,8 @@ export interface RasterLayerProps extends CompositeLayerProps {
}

const defaultProps = {
maxError: DEFAULT_MAX_ERROR,
debug: false,
debugOpacity: 0.5,
};

/**
Expand Down
8 changes: 7 additions & 1 deletion packages/raster-reproject/src/delatin.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,8 @@ const SAMPLE_POINTS: [number, number, number][] = [
[0, 0.5, 0.5], // edge 1–2
];

const DEFAULT_MAX_ERROR = 0.125;

export interface ReprojectionFns {
/**
* Convert from UV coordinates to input CRS coordinates.
Expand Down Expand Up @@ -132,7 +134,11 @@ export class RasterReprojector {
}

// refine the mesh until its maximum error gets below the given one
run(maxError: number = 1): void {
run(maxError: number = DEFAULT_MAX_ERROR): void {
if (maxError <= 0) {
throw new Error("maxError must be positive");
}

while (this.getMaxError() > maxError) {
this.refine();
}
Expand Down