Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow pystac 1.1.0 #20

Conversation

alexgleith
Copy link
Contributor

Simple as this, allow PySTAC 1.1.0. There are no significant differences between 1.0.0 and 1.1.0, as far as I know, and we're having build dependency problems because of this constraint.

setup.py Outdated
@@ -7,7 +7,7 @@

inst_reqs = [
"rasterio",
"pystac>=1.0.0,<1.1.0",
"pystac>=1.0.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@vincentsarago vincentsarago left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can't allow pystac version >1 or it will break everything as soon as pystac 2.0 is released

@alexgleith
Copy link
Contributor Author

Good point. Happy with <2.0.0?

setup.cfg Outdated Show resolved Hide resolved
@vincentsarago
Copy link
Member

@alexgleith thanks 🙏

FYI, I'm going to merge this and release it when tests ✅. I'll also update the changelog.

@vincentsarago vincentsarago self-requested a review October 7, 2021 09:21
@vincentsarago vincentsarago merged commit 4bcf4c7 into developmentseed:master Oct 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants