Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the raster_max_size and asset_roles arguments in create_stac_item #23

Merged
merged 1 commit into from
Oct 28, 2021

Conversation

alexgleith
Copy link
Contributor

  • Passes the raster_max_size argument to the appropriate function
  • Uses asset_roles and defaults to empty list

Closes #21

@vincentsarago vincentsarago self-requested a review October 28, 2021 21:29
@@ -284,7 +284,9 @@ def create_stac_item(
# add raster properties
raster_info = {}
if with_raster:
raster_info = {"raster:bands": get_raster_info(dataset)}
raster_info = {
"raster:bands": get_raster_info(dataset, max_size=raster_max_size)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦

@vincentsarago vincentsarago merged commit fc9bcf5 into developmentseed:master Oct 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Argument asset_roles is not used in create_stac_item
2 participants