added projjson if epsg not available #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🙏 @clausmichele please feel free to add a test using the file you shared |
|
@vincentsarago I added a test using the provided file, tests are successfully passing. |
rio_stac/stac.py
Outdated
| except AttributeError: | ||
| projjson = None | ||
| else: | ||
| epsg = src_dst.crs.to_epsg() |
There was a problem hiding this comment.
Can we do something like 👇
projjson = None
epsg = None
if src_dst.crs is not None:
epsg = src_dst.crs.to_epsg() if src_dst.crs.is_epsg_code else None
try:
projjson = src_dst.crs.to_dict(projjson=True)
except AttributeError:
passThere was a problem hiding this comment.
sure, thanks for the style improvement :)
|
CI errors with This only happens in python3.7 because rasterio 1.3 in not available for this version. I think we should allow |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves this issue: #40
Let me know if you have any comment or suggestion to improve this PR!
Example image to test the code:
spei30_19970215.zip