WIP: sketch geojson support #171
Conversation
| response_model_exclude={"minzoom", "maxzoom", "center"}, | ||
| response_model_exclude_none=True, | ||
| responses={200: {"description": "Return dataset's basic info."}}, | ||
| ) | ||
| def info( | ||
| src_path=Depends(self.path_dependency), | ||
| accept: Optional[JsonType] = Header(None), |
There was a problem hiding this comment.
tests are failing because by default we send content="*/*" which is not a member of JsonType
Having a defined accept values plays nice with OpenAPI but is too restrictive (?).
I'm not sure what's the best here, IMO just having as_geojson=True option would be simpler 🤷
There was a problem hiding this comment.
hmm I've never been a fan of how fastapi handles */*. Also you can't subclass enums which makes things difficult.
I think maybe separate info.json and info.geojson routes makes the most sense for now. It's definitely less standard but we already are using a pattern that doesn't rely on the accept header but instead the postfix of the route (ex /tilejson.json). So I'd say let's keep going with that pattern to keep things consistent.
I would definitely prefer an accept header longer term (its more standard HTTP), but maybe that is outside the scope of this PR. Switching to the use of an accept header to dictate api behavior seems like a larger topic.
There was a problem hiding this comment.
🙏 thanks @geospatial-jeff .json .geosjon 👌
ref: #166