-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Case insensitive query parameters #321
Case insensitive query parameters #321
Conversation
🙏 thanks for the PR @lorenzori As I said in the comment, I'm not 💯 sure we want to add this middleware by default but I think it's fine to add it in the code so people can add it to their own application. The I opened another issue #322 because mixing lowercase/uppercase will break the tilejson and wmts endpoints. |
…onal with API setting.
…onal with API setting. Only lowercase of query keys.
…onal with API setting. Hack to lowercase only query keys.
lowercase only Request keys
hey @vincentsarago thanks for the feedback! I have made the We have looked into making only the query keys lowercase instead of the entire query to avoid breaking the other endpoints and tests pass now locally, however is a bit of a hack as I didn't find an elegant solution with |
🙏 thanks @lorenzori, I added tests and fixed some format errors |
Hi, thank you for this awesome tool!
Some client applications require URL query parameters to be case-insensitive, so I have added a middleware to make all query parameters in the request lowercase following an example from an issue in FastAPI.
With this PR for example both
https://host/cog/WMTSCapabilities.xml?url=path/to/cog/...tif
andhttps://host/cog/WMTSCapabilities.xml?URL=path/to/cog/...tif
will work.
I am not 100% the WMTS standard says anything about this so happy with any feedback.