Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite imports in es6 folder #46

Closed
OliverJAsh opened this issue Feb 13, 2020 · 0 comments · Fixed by #50
Closed

Rewrite imports in es6 folder #46

OliverJAsh opened this issue Feb 13, 2020 · 0 comments · Fixed by #50
Labels
accepring PRs improvement New feature or request

Comments

@OliverJAsh
Copy link
Contributor

Currently the imports in the es6 folder reference fp-ts/lib when they should reference fp-ts/es6 (so that tree shaking can work properly), e.g.

https://unpkg.com/browse/@devexperts/remote-data-ts@2.0.3/es6/remote-data.js

import { constFalse, identity, constant } from 'fp-ts/lib/function';

This change has recently been made to other libraries such as io-ts and fp-ts-rxjs, for example: gcanti/fp-ts-rxjs@f35c926

https://unpkg.com/browse/fp-ts-rxjs@0.6.6/es6/Observable.js

Related issue: gcanti/fp-ts#1044

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepring PRs improvement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants