Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support arbitrary strings as names of entities #114

Closed
raveclassic opened this issue May 19, 2020 · 0 comments · Fixed by #115
Closed

Support arbitrary strings as names of entities #114

raveclassic opened this issue May 19, 2020 · 0 comments · Fixed by #115
Assignees
@raveclassic
Labels
language: typescript 3.0 Typescript language template for OpenAPI 3.0 spec

Comments

@raveclassic
Copy link
Contributor

  • current implementation doesn't process names in any way so that for names like Foo.Bar.Baz we generate interface Foo.Bar.Baz which is invalid TS
  • we need to remove any invalid characters from all names when generating TS
@raveclassic raveclassic added language: typescript 2.0 Typescript language template for Swagger 2.0 spec language: typescript 3.0 Typescript language template for OpenAPI 3.0 spec language: typescript asyncapi 2.0 Typescript language template for AsyncAPI 2.0 spec labels May 19, 2020
@raveclassic raveclassic self-assigned this May 19, 2020
@raveclassic raveclassic added language: typescript 3.0 Typescript language template for OpenAPI 3.0 spec and removed language: typescript 3.0 Typescript language template for OpenAPI 3.0 spec language: typescript asyncapi 2.0 Typescript language template for AsyncAPI 2.0 spec language: typescript 2.0 Typescript language template for Swagger 2.0 spec labels May 19, 2020
raveclassic added a commit that referenced this issue May 19, 2020
@raveclassic
feat: support arbitrary strings as type names in TS for OA3
8d67926 
closes #114

BREAKING CHANGE: type names and IO constant names now replace all non-alphanumeric characters with '_'
@raveclassic raveclassic mentioned this issue May 19, 2020
Merged
raveclassic added a commit that referenced this issue May 19, 2020
@raveclassic
feat: support arbitrary strings as type names in TS for OA3
f4467f0 
closes #114

BREAKING CHANGE: type names and IO constant names now replace all non-alphanumeric characters with '_'
raveclassic added a commit that referenced this issue May 20, 2020
@raveclassic
feat: support arbitrary strings as type names in TS for OA3
79cd66e 
closes #114

BREAKING CHANGE: type names and IO constant names now replace all non-alphanumeric characters with '_'
Nedgeva added a commit to Nedgeva/swagger-codegen-ts that referenced this issue Jul 29, 2020
@Nedgeva
fix: remove timezone detection from DateFromISODateStringIO
02c58a6 
fix: support windows os environment

fixed multiple errors that prevents from successful run on windows machine

feat: sketch file format

closes devexperts#76

refactor: relax specLikeCodec codec for sketch-121 schema

lint: remove unnecessary dependency

refactor: rename sketch parser to contain format version

refactor: fix opacity rendering

refactor: fix numeric rendering

chore: split document.ts to different files

chore: generate assets

docs: add a comment about a sketch-like structure

2.0.0-alpha.6

feat: implement support of kebab case in property names (devexperts#83)

closes devexperts#82

refactor: use Integer type from io-ts (devexperts#84)

BREAKING CHANGE: removed empty utils file

2.0.0-alpha.7

fix: fix encodeURIComponent in query serialization

2.0.0-alpha.8

fix: fix encodeURIComponent in query serialization

2.0.0-alpha.9

fix: fix '..' and '.' in spec names

BREAKING CHANGE: generate doesn't include `out` path in spec output
BREAKING CHANGE: language doesn't accept `out` path and can return `Fragment` to write to `out` directly

refactor: simplify resolveRef

BREAKING CHANGE: language is now a Reader of ResolveRefContext
BREAKING CHANGE: resolveRef now requires decoder as a second argument

chore: fix build

build: update prettier and eslint

style: update prettier and eslint

2.0.0-alpha.10

fix: revert join to resolve

feat: support cwd as `generate` argument

2.0.0-alpha.11

build: cleanup publishing artifact

build: cleanup publishing artifact

fix(sketch): avoid collision for names with counter

feat: support extract layers from sketch file

refactor: use traverseOptionEither

fix(sketch): add prefix to original layer name

2.0.0-alpha.12

fix: fix ResponseValidationError class in client

Fixes issue devexperts#93

fix: fix ResponseValidationError class in client

fix: fix ResponseValidationError class in client

refactor

fix: fix ResponseValidationError class to properly extend Error (devexperts#94)

closes devexperts#93

2.0.0-alpha.13

chore: update @devexeperts/* dependencies

2.0.0-alpha.14

feat: add `nullable` support for OpenAPI3

fix: fix OperationObject name generation without operationId

BREAKING CHANGE: if operation id is missing then url/pattern is included in the name

2.0.0-alpha.15

feat: expand sketch schema for support foreign symbols

feat: support date-time format (devexperts#100)

Added io-ts codec that supports date ignoring time

2.0.0-alpha.16

fix: add year padding to the codec (devexperts#101)

Added year padding to the codec to cover the case when backend returns  that should be treated as valid date

2.0.0-alpha.17

feat: filter operations response

BREAKING CHANGE: non-successful response types are filtered out of resulting response type

fix: incorrect generation "deprecated" jsdoc for method (devexperts#111)

fix: void response missing from union (devexperts#104) (devexperts#110)

BREAKING CHANGE: void response is added to resulting response type

fix: query string is incorrectly serialized for primitive parameters (devexperts#103) (devexperts#109)

build(deps): bump acorn from 5.7.3 to 5.7.4

Bumps [acorn](https://github.com/acornjs/acorn) from 5.7.3 to 5.7.4.
- [Release notes](https://github.com/acornjs/acorn/releases)
- [Commits](acornjs/acorn@5.7.3...5.7.4)

Signed-off-by: dependabot[bot] <support@github.com>

2.0.0-alpha.18

feat: support arbitrary strings as type names in TS for OA3

closes devexperts#114

BREAKING CHANGE: type names and IO constant names now replace all non-alphanumeric characters with '_'

2.0.0-alpha.19

feat: support arbitrary names in path/query params

BREAKING CHANGE: query/path param names are now escaped

2.0.0-alpha.20

fix: change function name in utils file

2.0.0-alpha.21

fix(ts-utils): remove timezone detection from DateFromISODateStringIO, add tests

fix(ts-utils): refactor DateFromISODateStringIO

fix(ts-utils): rename vars in util

fix(ts-utils): remove tests

fix(ts-utils): remove export keyword
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@raveclassic raveclassic

Labels
language: typescript 3.0 Typescript language template for OpenAPI 3.0 spec
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: support arbitrary strings as type names in TS for OA3 devexperts/swagger-codegen-ts
1 participant
@raveclassic