-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add nightly check for Product and Community registries #15
Conversation
* Add release yaml to workflows Signed-off-by: thepetk <thepetk@gmail.com> * Remove autogeneration of release notes Signed-off-by: thepetk <thepetk@gmail.com> * Update readme Signed-off-by: thepetk <thepetk@gmail.com> * Update Readme.md Signed-off-by: thepetk <thepetk@gmail.com> --------- Signed-off-by: thepetk <thepetk@gmail.com>
Signed-off-by: Michael Hoang <mhoang@redhat.com> Signed-off-by: thepetk <thepetk@gmail.com>
Signed-off-by: thepetk <thepetk@gmail.com>
Signed-off-by: Michael Hoang <mhoang@redhat.com> Signed-off-by: thepetk <thepetk@gmail.com>
* Update test paths Signed-off-by: thepetk <thepetk@gmail.com> * Update angular test resource Signed-off-by: thepetk <thepetk@gmail.com> * Remove projectAngularjs Signed-off-by: thepetk <thepetk@gmail.com> * Update containerfile test Signed-off-by: thepetk <thepetk@gmail.com> * Update django test resources Signed-off-by: thepetk <thepetk@gmail.com> * Update docker compose test resources Signed-off-by: thepetk <thepetk@gmail.com> * Update tests for docker compose with ports Signed-off-by: thepetk <thepetk@gmail.com> * Update test project dockerfile Signed-off-by: thepetk <thepetk@gmail.com> * Update express js port tests Signed-off-by: thepetk <thepetk@gmail.com> * Update flask port tests Signed-off-by: thepetk <thepetk@gmail.com> * Update golang test resources Signed-off-by: thepetk <thepetk@gmail.com> * Update jboss test resources Signed-off-by: thepetk <thepetk@gmail.com> * Update laravel test resources Signed-off-by: thepetk <thepetk@gmail.com> * Update test micronaut resources Signed-off-by: thepetk <thepetk@gmail.com> * Update container docker file nested tests Signed-off-by: thepetk <thepetk@gmail.com> * Update nuxt and next js tests Signed-off-by: thepetk <thepetk@gmail.com> * Update port test for quarkus Signed-off-by: thepetk <thepetk@gmail.com> * Update reactjs tests Signed-off-by: thepetk <thepetk@gmail.com> * Remove port test project quarkus Signed-off-by: thepetk <thepetk@gmail.com> * Update rest of port tests Signed-off-by: thepetk <thepetk@gmail.com> * Fix issue with ip host go format Signed-off-by: thepetk <thepetk@gmail.com> * Update test resources Signed-off-by: thepetk <thepetk@gmail.com> * Finalize new component detection format Signed-off-by: thepetk <thepetk@gmail.com> --------- Signed-off-by: thepetk <thepetk@gmail.com>
* Create dependabot.yml Signed-off-by: thepetk <thepetk@gmail.com> * Update dependabot.yml Signed-off-by: thepetk <thepetk@gmail.com> * Update realease.yaml (#2) Signed-off-by: thepetk <thepetk@gmail.com> * adding proposal for dockerfile components (#3) Signed-off-by: Michael Hoang <mhoang@redhat.com> Signed-off-by: thepetk <thepetk@gmail.com> * Merge all test resources (#6) * Update test paths Signed-off-by: thepetk <thepetk@gmail.com> * Update angular test resource Signed-off-by: thepetk <thepetk@gmail.com> * Remove projectAngularjs Signed-off-by: thepetk <thepetk@gmail.com> * Update containerfile test Signed-off-by: thepetk <thepetk@gmail.com> * Update django test resources Signed-off-by: thepetk <thepetk@gmail.com> * Update docker compose test resources Signed-off-by: thepetk <thepetk@gmail.com> * Update tests for docker compose with ports Signed-off-by: thepetk <thepetk@gmail.com> * Update test project dockerfile Signed-off-by: thepetk <thepetk@gmail.com> * Update express js port tests Signed-off-by: thepetk <thepetk@gmail.com> * Update flask port tests Signed-off-by: thepetk <thepetk@gmail.com> * Update golang test resources Signed-off-by: thepetk <thepetk@gmail.com> * Update jboss test resources Signed-off-by: thepetk <thepetk@gmail.com> * Update laravel test resources Signed-off-by: thepetk <thepetk@gmail.com> * Update test micronaut resources Signed-off-by: thepetk <thepetk@gmail.com> * Update container docker file nested tests Signed-off-by: thepetk <thepetk@gmail.com> * Update nuxt and next js tests Signed-off-by: thepetk <thepetk@gmail.com> * Update port test for quarkus Signed-off-by: thepetk <thepetk@gmail.com> * Update reactjs tests Signed-off-by: thepetk <thepetk@gmail.com> * Remove port test project quarkus Signed-off-by: thepetk <thepetk@gmail.com> * Update rest of port tests Signed-off-by: thepetk <thepetk@gmail.com> * Fix issue with ip host go format Signed-off-by: thepetk <thepetk@gmail.com> * Update test resources Signed-off-by: thepetk <thepetk@gmail.com> * Finalize new component detection format Signed-off-by: thepetk <thepetk@gmail.com> --------- Signed-off-by: thepetk <thepetk@gmail.com> * Run tidy Signed-off-by: thepetk <thepetk@gmail.com> * Update devfile_recognizer and models Signed-off-by: thepetk <thepetk@gmail.com> * Update cli Signed-off-by: thepetk <thepetk@gmail.com> * Update docs Signed-off-by: thepetk <thepetk@gmail.com> * Add test cases for versions cli args Signed-off-by: thepetk <thepetk@gmail.com> * Fix sec alert Signed-off-by: thepetk <thepetk@gmail.com> * Fix typo Signed-off-by: thepetk <thepetk@gmail.com> --------- Signed-off-by: thepetk <thepetk@gmail.com> Signed-off-by: Michael Hoang <mhoang@redhat.com> Co-authored-by: Michael Hoang <35011707+mike-hoang@users.noreply.github.com> Signed-off-by: thepetk <thepetk@gmail.com>
Signed-off-by: thepetk@gmail.com Signed-off-by: thepetk@gmail.com Signed-off-by: thepetk <thepetk@gmail.com>
* Remove dependabot Signed-off-by: thepetk@gmail.com Signed-off-by: thepetk <thepetk@gmail.com> * Add versions to alizer devfile response Signed-off-by: thepetk <thepetk@gmail.com> * Update readme.md Signed-off-by: thepetk <thepetk@gmail.com> * Update naming and devfile models in the proposal Signed-off-by: thepetk <thepetk@gmail.com> * Update code naming Signed-off-by: thepetk <thepetk@gmail.com> * Update tests after renaming Signed-off-by: thepetk <thepetk@gmail.com> --------- Signed-off-by: thepetk@gmail.com Signed-off-by: thepetk <thepetk@gmail.com>
Signed-off-by: Michael Hoang <mhoang@redhat.com> Signed-off-by: thepetk <thepetk@gmail.com>
* Add test coverage workflow Signed-off-by: thepetk <thepetk@gmail.com> * Update ci.yaml Signed-off-by: thepetk <thepetk@gmail.com> * Add separate check for code coverage Signed-off-by: thepetk <thepetk@gmail.com> * Move code report in ci file Signed-off-by: thepetk <thepetk@gmail.com> * Add .codecov.yaml Signed-off-by: thepetk <thepetk@gmail.com> * Update workflow Signed-off-by: thepetk <thepetk@gmail.com> * Bump up setup-go Signed-off-by:thepetk <thepetk@gmail.com> --------- Signed-off-by: thepetk <thepetk@gmail.com>
Signed-off-by: Michael Hoang <mhoang@redhat.com> Signed-off-by: thepetk <thepetk@gmail.com>
Signed-off-by: thepetk <thepetk@gmail.com>
Signed-off-by: thepetk <thepetk@gmail.com>
Signed-off-by: thepetk <thepetk@gmail.com>
Signed-off-by: thepetk <thepetk@gmail.com>
Signed-off-by: thepetk <thepetk@gmail.com>
Signed-off-by:thepetk <thepetk@gmail.com> Signed-off-by: thepetk <thepetk@gmail.com>
Signed-off-by: thepetk <thepetk@gmail.com>
Signed-off-by: thepetk <thepetk@gmail.com>
Signed-off-by: thepetk <thepetk@gmail.com>
Signed-off-by: thepetk <thepetk@gmail.com>
Signed-off-by: thepetk <thepetk@gmail.com>
signed-off-by: thepetk <thepetk@gmail.com> Signed-off-by: thepetk <thepetk@gmail.com>
Signed-off-by: thepetk <thepetk@gmail.com>
Signed-off-by: thepetk <thepetk@gmail.com>
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #15 +/- ##
===========================================
+ Coverage 37.91% 66.56% +28.64%
===========================================
Files 9 10 +1
Lines 1221 1358 +137
===========================================
+ Hits 463 904 +441
+ Misses 729 394 -335
- Partials 29 60 +31
☔ View full report in Codecov by Sentry. |
Signed-off-by: thepetk <thepetk@gmail.com>
Signed-off-by: thepetk <thepetk@gmail.com>
Signed-off-by: thepetk <thepetk@gmail.com>
Signed-off-by: thepetk <thepetk@gmail.com>
Signed-off-by: thepetk <thepetk@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Overall looks good, just a few nits that I think should be addressed
Signed-off-by: thepetk <thepetk@gmail.com>
Signed-off-by: thepetk <thepetk@gmail.com>
Signed-off-by: thepetk <thepetk@gmail.com>
All items have been addressed @mike-hoang :) |
Signed-off-by: thepetk <thepetk@gmail.com>
@mike-hoang I've gone through again the workflow (I had in mind what you said about the cleaning process) and I made some further fixes:
For the |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: mike-hoang, thepetk The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What does this PR do?
This PR creates a new workflow
check_registry.yaml
which will be scheduled for every day at 03.00 UTC. In this workflow we are trying to run an E2E test by running alizer against a stack's starterprojects. We expect that the devfile of this stack will be inside the list of alizer's matchings.The registries we are checking are:
In order to create a complete JSON for all registry entries we are running the
check_registry.go
file which is responsible to gather all details from the given registries:<registryUrl>/v2index
response and for each stack/sample fetched tries to getch the devfile details:If a stack has different layout and we don't have available the
git.remote.origin
we are using thegetProjectReplacements
method.After the JSON is generated the script checks every entry, clones the given repo, runs alizer against it and checks the results.
If the expected devfile is not inside the list then the process
exit 1
.Which issue(s) does this PR fix
fixes devfile/api#1165
PR acceptance criteria
Testing and documentation do not need to be complete in order for this PR to be approved. We just need to ensure tracking issues are opened.
Unit/Functional tests
Documentation
How to test changes / Special notes to the reviewer
Locally you can try to run
There is also a test run here: https://github.com/thepetk/devfile-alizer/actions/runs/5681161565