Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Devtools Week] Create linux arm64 binary after every release #40

Merged
merged 2 commits into from
Dec 13, 2023

Conversation

thepetk
Copy link
Contributor

@thepetk thepetk commented Dec 12, 2023

What does this PR do?

This PR adds support for an linux/arm64 binary on every release we make for alizer.

Which issue(s) does this PR fix

Part of the devtools week

PR acceptance criteria

Testing and documentation do not need to be complete in order for this PR to be approved. We just need to ensure tracking issues are opened.

  • Unit/Functional tests
  • Documentation

How to test changes / Special notes to the reviewer

An example release is here: https://github.com/thepetk/devfile-alizer/releases/tag/v1.3.1

Signed-off-by: thepetk <thepetk@gmail.com>
Copy link
Member

@michael-valdron michael-valdron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also include darwin/arm64 for running releases of the tool directly on macOS.

https://gist.github.com/asukakenji/f15ba7e588ac42795f421b48b8aede63#platform-values

Signed-off-by: thepetk <thepetk@gmail.com>
Copy link

codecov bot commented Dec 13, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (719af19) 70.49% compared to head (b48933e) 73.12%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #40      +/-   ##
==========================================
+ Coverage   70.49%   73.12%   +2.63%     
==========================================
  Files          11       11              
  Lines        1566     1563       -3     
==========================================
+ Hits         1104     1143      +39     
+ Misses        395      351      -44     
- Partials       67       69       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@thepetk
Copy link
Contributor Author

thepetk commented Dec 13, 2023

We should also include darwin/arm64 for running releases of the tool directly on macOS.

https://gist.github.com/asukakenji/f15ba7e588ac42795f421b48b8aede63#platform-values

@michael-valdron done!

Copy link
Member

@michael-valdron michael-valdron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

openshift-ci bot commented Dec 13, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: michael-valdron, thepetk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [michael-valdron,thepetk]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@thepetk thepetk merged commit 53cbc4a into devfile:main Dec 13, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants