-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Devtools Week] Create linux arm64 binary after every release #40
Conversation
Signed-off-by: thepetk <thepetk@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should also include darwin/arm64
for running releases of the tool directly on macOS.
https://gist.github.com/asukakenji/f15ba7e588ac42795f421b48b8aede63#platform-values
Signed-off-by: thepetk <thepetk@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #40 +/- ##
==========================================
+ Coverage 70.49% 73.12% +2.63%
==========================================
Files 11 11
Lines 1566 1563 -3
==========================================
+ Hits 1104 1143 +39
+ Misses 395 351 -44
- Partials 67 69 +2 ☔ View full report in Codecov by Sentry. |
@michael-valdron done! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: michael-valdron, thepetk The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What does this PR do?
This PR adds support for an
linux/arm64
binary on every release we make for alizer.Which issue(s) does this PR fix
Part of the devtools week
PR acceptance criteria
Testing and documentation do not need to be complete in order for this PR to be approved. We just need to ensure tracking issues are opened.
How to test changes / Special notes to the reviewer
An example release is here: https://github.com/thepetk/devfile-alizer/releases/tag/v1.3.1