-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Registry operator should be in sync with operator SDK releases #1106
Comments
related to epic: #1007 |
Matching status of #1007 |
Is there anything further information needed for this issue to be ready for a sprint? cc: @kim-tsao |
/area registry |
Need to start next sprint due to giving focus towards completion of other tasks. |
Adding all changes needed for |
Migrating from Ginkgo v1 to Ginkgo v2: https://onsi.github.io/ginkgo/MIGRATING_TO_V2 |
Troubleshooting problem:
|
Current version of the operator sdk actually should be v1.28: https://github.com/devfile/registry-operator/blob/dea070ae240936e290c59e7a1490d836137cbc7d/README.md?plain=1#L30 Adding all
|
This was a result of the |
Continuing in Sprint 245 due to vacation leave. |
Moving item to 245 as requested |
Continuing to use full account and namespace names under role bindings. |
Resolved these errors by using a different service account name for the operator, previously using the |
Multi arch build and push rule |
Created Issue is ready for review: devfile/registry-operator#45 |
Need to merge openshift/release#42759 before proceeding. |
openshift/release#42759 has been merged, unblocked. |
Set back with unexpected integration test errors on the OpenShift CI: https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/devfile_registry-operator/45/pull-ci-devfile-registry-operator-main-v4.12-registry-operator-integration-test/1696556383018684416 |
This was resolved setting |
Testing is failing possibly due to missed Ginkgo V2 changes for creating a timeout to allow the test devfile registries to deploy. |
This does not seem to be the case, the integration tests seem to fail if the operator is deployed during
|
I probably encountered the same problem when testing the operator, working on #46. I have seen that if the operator is not deployed before running |
I suspect the same thing, it looks like in the integration test suite we are checking if the pod is running but not if the pod is ready: https://github.com/devfile/registry-operator/blob/9ac99619807eccb75f0cdfff01c189d71c5bd921/tests/integration/pkg/client/pod.go#L66 For this issue I'm trying a short term fix https://github.com/michael-valdron/devfile-registry-operator/blob/2f45c9e2ec83f7444d13203e8d1f068aee12e184/.ci/openshift_integration.sh#L32, but moving forward we should be checking readiness as well. I'll open an issue for this after I have resolved the current issue. |
openshift-ci is currently failing during setup of the environment: https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/devfile_registry-operator/45/pull-ci-devfile-registry-operator-main-v4.12-registry-operator-integration-test/1696984101262725120 This has pushed the target date for completing this item. |
It looks like this has been resolved now: https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/devfile_registry-operator/45/pull-ci-devfile-registry-operator-main-v4.12-registry-operator-integration-test/1697251234546716672 |
/kind user-story
Which area this user story is related to?
/area registry
User Story
As a registry operator provider, I want to ensure the operator sdk is kept up to date and in sync with supported k8s and go versions so there is no breakage when running makefile commands.
Acceptance Criteria
Target Date: 08-31-2023
The text was updated successfully, but these errors were encountered: