Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add min-version and max-version params to alizer CLI #1171

Closed
Tracked by #1170
thepetk opened this issue Jun 30, 2023 · 2 comments · Fixed by devfile/alizer#5
Closed
Tracked by #1170

Add min-version and max-version params to alizer CLI #1171

thepetk opened this issue Jun 30, 2023 · 2 comments · Fixed by devfile/alizer#5
Assignees
@thepetk
Labels
area/alizer Enhancement or issue related to the alizer repo

Comments

@thepetk
Copy link
Contributor

thepetk commented Jun 30, 2023

Which area/kind this issue is related to?

/area alizer

Issue Description

As part of the proposal for #1170 two CLI arguments have to be introduced. First the min-version and then the max-version args. As stated in the proposal the min version represents the minimum version of the matched devfile and the max version the maximum. In case the minimum version is greater than the maximum an error should be raised.

Target Date: 30 June 2023
@openshift-ci openshift-ci bot added the area/alizer Enhancement or issue related to the alizer repo label Jun 30, 2023
@thepetk thepetk moved this to In Review 👀 in Devfile Project Jun 30, 2023
@thepetk thepetk self-assigned this Jun 30, 2023
@thepetk
Copy link
Contributor Author

thepetk commented Jun 30, 2023

Follow comments inside the old issue: redhat-developer/alizer#226

This was referenced Jun 30, 2023
Closed
Closed
Merged
@thepetk
Copy link
Contributor Author

thepetk commented Jul 5, 2023

I've update the PR and now is again under reveiw

@thepetk thepetk moved this from In Review 👀 to Done ✅ in Devfile Project Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thepetk thepetk

Labels
area/alizer Enhancement or issue related to the alizer repo
Projects
Devfile Project
Status: Done ✅
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add min max cli args thepetk/devfile-alizer
1 participant
@thepetk