Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor improvments on Alizer's min/max version CLI arguments #1182

Closed
Tracked by #1170
thepetk opened this issue Jul 7, 2023 · 0 comments · Fixed by devfile/alizer#11
Closed
Tracked by #1170

Minor improvments on Alizer's min/max version CLI arguments #1182

thepetk opened this issue Jul 7, 2023 · 0 comments · Fixed by devfile/alizer#11
Assignees
Labels
area/alizer Enhancement or issue related to the alizer repo

Comments

@thepetk
Copy link
Contributor

thepetk commented Jul 7, 2023

Which area/kind this issue is related to?

/area alizer

Issue Description

As discussed here #1170 (comment) after the addition of min-version and max-version a minor improvement could be made regarding the naming of the argument and the response of alizer.

  • Right now we use min-version and max-version and we may have some confusion between devfile version and schemaversion fields. So we could rename the args to - min-schema-version and max-schema-version

  • Inside the response of alizer we could include the version of a matched devfile:

$ ./alizer devfile --min-schema-version 2.2.0 --max-schema-version 2.2.0 ~/github/thepetk/go-ps-script

[
	{
		"Name": "go",
		"Language": "Go",
		"ProjectType": "Go",
		"Tags": [
			"Go"
		],
		"Versions": [
			{
				"SchemaVersion": "2.2.0",
				"Version": "1.1.1",
				"Default": false
			},
			{
				"SchemaVersion": "2.2.0",
				"Version": "1.1.0",
				"Default": false
			}
		]
	}
]
@openshift-ci openshift-ci bot added the area/alizer Enhancement or issue related to the alizer repo label Jul 7, 2023
@thepetk thepetk moved this to In Progress 🚧 in Devfile Project Jul 7, 2023
@thepetk thepetk self-assigned this Jul 7, 2023
@thepetk thepetk moved this from In Progress 🚧 to In Review 👀 in Devfile Project Jul 7, 2023
@thepetk thepetk moved this from In Review 👀 to Done ✅ in Devfile Project Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/alizer Enhancement or issue related to the alizer repo
Projects
Status: Done ✅
Development

Successfully merging a pull request may close this issue.

1 participant