Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support For Other Languages In Alizer Port Detection Optimizations #1376

Closed
3 tasks
Jdubrick opened this issue Dec 7, 2023 · 3 comments
Closed
3 tasks

Support For Other Languages In Alizer Port Detection Optimizations #1376

Jdubrick opened this issue Dec 7, 2023 · 3 comments
Labels
area/alizer Enhancement or issue related to the alizer repo lifecycle/rotten Rotten items. These items have been stale for 60 days and are now closed. lifecycle/stale Stale items. These items have not been updated for 90 days.

Comments

@Jdubrick
Copy link
Contributor

Jdubrick commented Dec 7, 2023

Which area/kind this issue is related to?

/area alizer

Issue Description

This issue stems from the implementation of #1337 where we were making optimizations to Alizer's port detection process, specifically for Go. It would be nice to made changes to the GenerateApplicationFileFromFilters function to allow each language suffix to have its own list of excluded filepaths.

This can potentially be implemented by having a map in the form {"<language suffix>": "[slice of excluded filepaths]"} where we first check if the suffix requires any exclusion. By implementing it this way we prevent unnecessary time spent comparing every file to every excluded filepath, even if their languages are different.

Target Odo version

Acceptance Criteria

  • Solution supports the easy addition of excluded filepaths for any language
  • Unit tests are created for new additions
  • Documentation updated as required
@openshift-ci openshift-ci bot added the area/alizer Enhancement or issue related to the alizer repo label Dec 7, 2023
@Jdubrick Jdubrick moved this to Refinement in Devfile Project Jan 3, 2024
Copy link

github-actions bot commented Mar 7, 2024

This issue is stale because it has been open for 90 days with no activity. Remove stale label or comment or this will be closed in 60 days.

@github-actions github-actions bot added the lifecycle/stale Stale items. These items have not been updated for 90 days. label Mar 7, 2024
@github-actions github-actions bot added the lifecycle/rotten Rotten items. These items have been stale for 60 days and are now closed. label May 6, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale May 6, 2024
@github-project-automation github-project-automation bot moved this from Refinement to Done ✅ in Devfile Project May 6, 2024
@Jdubrick Jdubrick removed lifecycle/stale Stale items. These items have not been updated for 90 days. lifecycle/rotten Rotten items. These items have been stale for 60 days and are now closed. labels May 7, 2024
@Jdubrick Jdubrick reopened this May 7, 2024
@Jdubrick
Copy link
Contributor Author

Jdubrick commented May 7, 2024

The completion of this issue would bring significant performance enhancements to the Alizer port detection process so it should remain open.

@Jdubrick Jdubrick moved this from Done ✅ to Refinement in Devfile Project May 13, 2024
Copy link

This issue is stale because it has been open for 90 days with no activity. Remove stale label or comment or this will be closed in 60 days.

@github-actions github-actions bot added the lifecycle/stale Stale items. These items have not been updated for 90 days. label Sep 23, 2024
@github-actions github-actions bot added the lifecycle/rotten Rotten items. These items have been stale for 60 days and are now closed. label Nov 22, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Nov 22, 2024
@github-project-automation github-project-automation bot moved this from Refinement to Done ✅ in Devfile Project Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/alizer Enhancement or issue related to the alizer repo lifecycle/rotten Rotten items. These items have been stale for 60 days and are now closed. lifecycle/stale Stale items. These items have not been updated for 90 days.
Projects
Status: Done ✅
Development

No branches or pull requests

1 participant