-
Notifications
You must be signed in to change notification settings - Fork 73
Closed
devfile/registry-operator
#80Labels
area/registryDevfile registry for stacks and infrastructureDevfile registry for stacks and infrastructure
Description
Which area/kind this issue is related to?
/area registry
Issue Description
Currently, the registry operator hostname setup only uses the CR name value for the hostname part, for openshift deployments and how the helm chart sets up the hostname _template.tpl#L16, the CR name is coupled with the namespace name to create the hostname.
The registry operator source should be changed to something of the following:
GetDevfileRegistryIngress
func GetDevfileRegistryIngress(cr *registryv1alpha1.DevfileRegistry) string {
return GetHostname(cr) + "." + cr.Spec.K8s.IngressDomain
}
GetHostname
func GetHostname(cr *registryv1alpha1.DevfileRegistry) string {
return fmt.Sprintf("%s-%s", cr.Name, cr.Namespace)
}
Parent Epic: #1274
Acceptance Criteria
- Create getter function to receive the hostname part of the ingress address
- Create hostname using the format
<DevfileRegistry.Name>-<DevfileRegistry.Namespace>
- Create hostname using the format
- Update
GetDevfileRegistryIngress
to couple the result of the hostname getter function and the set ingress domainDevfileRegistry.Spec.K8s.IngressDomain
- Ensure integration test cases are passing
Metadata
Metadata
Assignees
Labels
area/registryDevfile registry for stacks and infrastructureDevfile registry for stacks and infrastructure
Type
Projects
Status
Done ✅