Allow volumes to be shared across components

[l0rd]

Odo will have a need for multiple components to mount the same volume. There isn’t an option in devfiles right now to define a volume once, and have multiple components mount that same volume.

To work around this, we’re proposing adding a way to the devfile spec that allows you to define a volume once (a top level ‘volumes’ field), then easily add it to other components via a ‘volumeMount’ field. This is similar to how Kubernetes pods handle volumes.

Example:

---
projects:
  - name: "my-project"
components:
  - container:
      image: "busybox"
      name: "mycontainer"
      memoryLimit: "128M"
      mountSources: true
      volumeMount:
        - name: my-data-volume
          path: /some/folder
  - kubernetes:
      referenceContent: |
        kind: Pod
        metadata:
          name: sample-pod
        spec:
          containers:
            image: docker.io/my-sample-image:latest
            volumeMounts:
            - mountPath: /some/path
              name: my-data-volume
  - volume:
     name: my-data-volume
     size: 5Gi

[l0rd]

cc @johnmcollier @elsony

[l0rd]

@johnmcollier will provide another example using a component of type Kubernetes

[sleshchenko]

Does it duplicate #16 ?

There is another interesting option to think about - add an ability to specify PVC name for volume eclipse-che/che#15652

[johnmcollier]

@sleshchenko Yeah it's the same, since there's already some discussion here, I'll close out my issue in favour of this one.

[johnmcollier]

Sample with Kubernetes component:

---
projects:
  - name: "my-project"
components:
  - container:
      image: "busybox"
      name: "mycontainer"
      memoryLimit: "128M"
      mountSources: true
      volumeMount:
        - name: my-data-volume
          path: /some/folder
  - kubernetes:
      referenceContent: |
        kind: Pod
        metadata:
          name: sample-pod
        spec:
          containers:
            image: docker.io/my-sample-image:latest
            volumeMounts:
            - mountPath: /some/path
              name: my-data-volume
  - volume:
     name: my-data-volume
     size: 5Gi

In this scenario, the Kubernetes component references the my-data-volume defined in the volume section under components, rather than having to define one via a persistent volume claim in the pod spec.

[l0rd]

Reviewed and approved the version provided on this comment.
We also agreed that the name field should be mandatory for volume components.

[davidfestal]

implemented