endpoint protocol type should be EndpointProtocol

[yangcao77]

Endpoint protocol type should be EndpointProtocol instead of string

api/pkg/apis/workspaces/v1alpha2/endpoint.go

Line 86 in 6aa1dc0

Protocol string `json:"protocol,omitempty"`

[mmulholla]

This change is problematic, according to the api doc the endpoint can be set to https or wss, but this change does not allow these values.

The way for a user to, for example, set https is to set the protocol to http and the secure attribute to true/.

Why have two attribiutes? Who is responsible for converting the protocol http and secure true to protocol https?

[yangcao77]

@mmulholl IMO, the problem is unrelated to this change. the protocol type should be EndpointProtocol, not string, for sure. The issue is because https and wss is not included in the schema enum.

you might want to argue with this line, when EndpointProtocol is defined

api/pkg/apis/workspaces/v1alpha2/endpoint.go

Lines 5 to 6 in 6aa1dc0

	// +kubebuilder:validation:Enum=http;ws;tcp;udp
	type EndpointProtocol string

[mmulholla]

@yangcao77 this change is good but it was the catalyst that brought the issue I discuss to our attention. In this sense it introduced the problem and this is arguabally an incomplete fix.