Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

metadata of typescript DevWorkspace types is just object #494

Closed
Tracked by #20068
sleshchenko opened this issue Jun 14, 2021 · 2 comments · Fixed by #551
Closed
Tracked by #20068

metadata of typescript DevWorkspace types is just object #494

sleshchenko opened this issue Jun 14, 2021 · 2 comments · Fixed by #551

Comments

@sleshchenko
Copy link
Member

Describe the bug
metadata of typescript DevWorkspace types is just object, but for clients it's needed to know that it has all fields from K8s API, like namespace, name, annotations https://github.com/devfile/api/blob/main/pkg/apis/workspaces/v1alpha2/devworkspace_types.go#L80

To Reproduce
Steps to reproduce the behavior:

  1. Import devfile/api somewhere in typescript project.
  2. Check V1alpha2DevWorkspace or V1alpha2DevWorkspaceTempalate. Metadata there is just an object

Expected behavior
it's expected it has all field from K8s ObjectMeta.

@sleshchenko

This comment has been minimized.

@sleshchenko
Copy link
Member Author

sleshchenko commented Jul 9, 2021

related controller-gen PR kubernetes-sigs/controller-tools#557.
metadata can have limited number of fields: name, namespace, labels, annotations and finalizers
Added in #524.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant