Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update python runtime version for release-typescript-models job #1051

Merged
merged 2 commits into from
Mar 7, 2023
Merged

Update python runtime version for release-typescript-models job #1051

merged 2 commits into from
Mar 7, 2023

Conversation

michael-valdron
Copy link
Member

@michael-valdron michael-valdron commented Mar 7, 2023 •
edited
Loading

What does this PR do?

Updates the python runtime under the release-typescript-models job from 3.9.2 to 3.9.12 due to the current being unsupported by the latest Ubuntu runner. Also updates setup-python to v4.

Which issue(s) does this PR fix

fixes #1048

PR acceptance criteria

Testing and documentation do not need to be complete in order for this PR to be approved. We just need to ensure tracking issues are opened.

  • Open new test/doc issues under the devfile/api repo
  • Check each criteria if:
  • There is a separate tracking issue. Add the issue link under the criteria
    or
  • test/doc updates are made as part of this PR
  • If unchecked, explain why it's not needed

How to test changes / Special notes to the reviewer

@michael-valdron
bump python runtime version for 'release-typescript-models' job.
8e7a06f 
Signed-off-by: Michael Valdron <mvaldron@redhat.com>
@codecov
Copy link

codecov bot commented Mar 7, 2023 •
edited
Loading

Codecov Report

Patch and project coverage have no change.

Comparison is base (04373ec) 35.64% compared to head (a9500e6) 35.64%.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1051   +/-   ##
=======================================
  Coverage   35.64%   35.64%           
=======================================
  Files          52       52           
  Lines        6669     6669           
=======================================
  Hits         2377     2377           
  Misses       4147     4147           
  Partials      145      145

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@openshift-ci openshift-ci bot added the lgtm label Mar 7, 2023
@openshift-ci
Copy link

openshift-ci bot commented Mar 7, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: amisevsk, michael-valdron

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

amisevsk
amisevsk reviewed Mar 7, 2023
View reviewed changes
Copy link
Contributor

@amisevsk amisevsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worth noting that the setup-python action is up to v4 now -- it may be worth updating that as well.

@michael-valdron
bump setup-python action to v4 for 'release-typescript-models' job.
a9500e6 
Signed-off-by: Michael Valdron <mvaldron@redhat.com>
@openshift-ci openshift-ci bot removed the lgtm label Mar 7, 2023
@openshift-ci
Copy link

openshift-ci bot commented Mar 7, 2023

New changes are detected. LGTM label has been removed.

@michael-valdron michael-valdron merged commit 9057a5d into devfile:main Mar 7, 2023
yangcao77 added a commit that referenced this pull request Oct 11, 2023
@yangcao77 @kim-tsao
@schultzp2020 @michael-valdron @johnmcollier @feloy @thepetk
2.2.1 release (#1287)
1ae41b5 
* 2.2.0 release cut

Signed-off-by: Stephanie <yangcao@redhat.com>

* enable gosec (#969)

* enable gosec

Signed-off-by: Kim Tsao <ktsao@redhat.com>

* Fix G601 errors

Signed-off-by: Kim Tsao <ktsao@redhat.com>

* Fix warnings

Signed-off-by: Kim Tsao <ktsao@redhat.com>

* Add newline

Signed-off-by: Kim Tsao <ktsao@redhat.com>

Signed-off-by: Kim Tsao <ktsao@redhat.com>

* Update the devfile spec to 2.2.1 alpha (#980)

Signed-off-by: Paul Schultz <pschultz@pobox.com>

* Bump kubernetes-client/gen revision to fix git dubious ownership error (#1045)

* bump kubernetes-client/gen revision to fix git dubious ownership error

Signed-off-by: Michael Valdron <mvaldron@redhat.com>

* whitespace changes.

Signed-off-by: Michael Valdron <mvaldron@redhat.com>

* set openapi generator ref to version which supports typescript generation.

Signed-off-by: Michael Valdron <mvaldron@redhat.com>

---------

Signed-off-by: Michael Valdron <mvaldron@redhat.com>

* Fix Dependabot issues (#1047)

* fix dependabot issues, requires a bump in k8s versions

Signed-off-by: Kim Tsao <ktsao@redhat.com>

* re-generated devworkspace files

Signed-off-by: Kim Tsao <ktsao@redhat.com>

* Vendor updates

Signed-off-by: Kim Tsao <ktsao@redhat.com>

---------

Signed-off-by: Kim Tsao <ktsao@redhat.com>

* fix gosec v2.14.0 (#1034)

Signed-off-by: Michael Valdron <mvaldron@redhat.com>

* Update python runtime version for `release-typescript-models` job (#1051)

* bump python runtime version for 'release-typescript-models' job.

Signed-off-by: Michael Valdron <mvaldron@redhat.com>

* bump setup-python action to v4 for 'release-typescript-models' job.

Signed-off-by: Michael Valdron <mvaldron@redhat.com>

---------

Signed-off-by: Michael Valdron <mvaldron@redhat.com>

* Add workflow for managing stale issues & PRs (#1055)

Adds a GitHub workflow for managing stale & rotten issues and PRs. 

Issues & PRs are marked stale after 90 days of inactivity. After 60 further days, they are marked as rotten and closed.

* Clarify hotReloadCapable field (#1091)

* Clarify hotReloadCapable field

Signed-off-by: Philippe Martin <phmartin@redhat.com>

* Auto-generated

Signed-off-by: Philippe Martin <phmartin@redhat.com>

* Specify isDefault

Signed-off-by: Philippe Martin <phmartin@redhat.com>

* Clarify description

Signed-off-by: Philippe Martin <phmartin@redhat.com>

---------

Signed-off-by: Philippe Martin <phmartin@redhat.com>

* update kubernetes/openshift endpoint validation (#1098)

* update endpoint validation

Signed-off-by: Stephanie <yangcao@redhat.com>

* update unit test

Signed-off-by: Stephanie <yangcao@redhat.com>

* update the test error check to be more clear

Signed-off-by: Stephanie <yangcao@redhat.com>

* add unit test for two kube components

Signed-off-by: Stephanie <yangcao@redhat.com>

---------

Signed-off-by: Stephanie <yangcao@redhat.com>

* Update release doc (#1110)

Signed-off-by: Kim Tsao <ktsao@redhat.com>

* Update directly executed scripts inside workflows (#1107)

* Update directly executed scripts on workflows

Signed-off-by: thepetk <thepetk@gmail.com>

* Update directly executed scripts on bash scripts

Signed-off-by: thepetk <thepetk@gmail.com>

---------

Signed-off-by: thepetk <thepetk@gmail.com>

* Add area alizer label to all issue templates (#1149)

Signed-off-by: thepetk <thepetk@gmail.com>

* Update deprecated github actions to latest version (#1231)

* Update deprecated github actions

Signed-off-by: thepetk <thepetk@gmail.com>

* Remove jsonschema dep from validate samples

Signed-off-by: thepetk <thepetk@gmail.com>

---------

Signed-off-by: thepetk <thepetk@gmail.com>

* Add license header file and script (#1256)

* add license header file

Signed-off-by: Michael Valdron <mvaldron@redhat.com>

* addlicense script

Signed-off-by: Michael Valdron <mvaldron@redhat.com>

* update README with instructions on adding license headers

Signed-off-by: Michael Valdron <mvaldron@redhat.com>

* update license headers under source files

Signed-off-by: Michael Valdron <mvaldron@redhat.com>

* remove license header from generated source

Signed-off-by: Michael Valdron <mvaldron@redhat.com>

* add_license.sh ignores zz_generated.* source files

Signed-off-by: Michael Valdron <mvaldron@redhat.com>

* check license headers script added

Signed-off-by: Michael Valdron <mvaldron@redhat.com>

* check license headers script added to CI workflow

Signed-off-by: Michael Valdron <mvaldron@redhat.com>

---------

Signed-off-by: Michael Valdron <mvaldron@redhat.com>

* add signoff

Signed-off-by: Stephanie <yangcao@redhat.com>

---------

Signed-off-by: Stephanie <yangcao@redhat.com>
Signed-off-by: Kim Tsao <ktsao@redhat.com>
Signed-off-by: Paul Schultz <pschultz@pobox.com>
Signed-off-by: Michael Valdron <mvaldron@redhat.com>
Signed-off-by: Philippe Martin <phmartin@redhat.com>
Signed-off-by: thepetk <thepetk@gmail.com>
Co-authored-by: Kim Tsao <84398375+kim-tsao@users.noreply.github.com>
Co-authored-by: Paul Schultz <pschultz@pobox.com>
Co-authored-by: Michael Valdron <michael.valdron@gmail.com>
Co-authored-by: Michael Valdron <mvaldron@redhat.com>
Co-authored-by: John Collier <jcollier@redhat.com>
Co-authored-by: Philippe Martin <phmartin@redhat.com>
Co-authored-by: Theofanis Petkos <thepetk@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amisevsk amisevsk amisevsk approved these changes

@yangcao77 yangcao77 Awaiting requested review from yangcao77

@johnmcollier johnmcollier Awaiting requested review from johnmcollier

Assignees

@amisevsk amisevsk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Python runtime version for release-typescript-models is currently unsupported
2 participants
@michael-valdron @amisevsk