-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add security.md #1627
Add security.md #1627
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1627 +/- ##
=======================================
Coverage 35.75% 35.75%
=======================================
Files 52 52
Lines 6696 6696
=======================================
Hits 2394 2394
Misses 4158 4158
Partials 144 144 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor nits, you don't need to incorporate these changes however lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a suggested change to the Reporting process section, other than that changes lgtm.
82c756c
to
b207132
Compare
Signed-off-by: thepetk <thepetk@gmail.com>
Signed-off-by: thepetk <thepetk@gmail.com>
Signed-off-by: thepetk <thepetk@gmail.com>
Co-authored-by: Jordan Dubrick <jdubrick@redhat.com> Signed-off-by: thepetk <thepetk@gmail.com>
Co-authored-by: Jordan Dubrick <jdubrick@redhat.com> Signed-off-by: thepetk <thepetk@gmail.com>
Co-authored-by: Jordan Dubrick <jdubrick@redhat.com> Signed-off-by: thepetk <thepetk@gmail.com>
Co-authored-by: Michael Valdron <michael.valdron@gmail.com> Signed-off-by: thepetk <thepetk@gmail.com>
298d73d
to
a2225c5
Compare
@michael-valdron I've updated the content |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Jdubrick, michael-valdron, thepetk, yangcao77 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description of Changes
This PR adds a security policy with vulnerability reporting instructions.
Related Issue(s)
Fixes #1629
Acceptance Criteria
Testing and documentation do not need to be complete in order for this PR to be approved. However, tracking issues must be opened for missing testing/documentation.
New testing and documentation issues can be opened under
devfile/api/issues
.You can check the respective criteria below if either of the following is true:
If criteria is left unchecked please provide an explanation why.
Unit/Functional tests
QE Integration test
Documentation
Client Impact
Tests Performed
Explain what tests you personally ran to ensure the changes are functioning as expected.
How To Test
Instructions for the reviewer on how to test your changes.
Notes To Reviewer
Any notes you would like to include for the reviewer.