Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Index server REST APIs docs #282

Merged
merged 6 commits into from
Jan 11, 2021
Merged

Conversation

GeekArthur
Copy link
Contributor

Signed-off-by: jingfu wang jingfu.j.wang@ibm.com

What does this PR do?

This PR adds the docs for index server REST APIs so that consumers (eg. Che) can refer to them.

Signed-off-by: jingfu wang <jingfu.j.wang@ibm.com>
@GeekArthur GeekArthur added the area/documentation Improvements or additions to documentation label Dec 16, 2020
@GeekArthur GeekArthur self-assigned this Dec 16, 2020
Signed-off-by: jingfu wang <jingfu.j.wang@ibm.com>
Signed-off-by: jingfu wang <jingfu.j.wang@ibm.com>
Signed-off-by: jingfu wang <jingfu.j.wang@ibm.com>
Signed-off-by: jingfu wang <jingfu.j.wang@ibm.com>
Copy link
Contributor

@elsony elsony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Approve based on the condition that we have confirmed the list of APIs needed by the Che team (especially around resource download APIs).

Signed-off-by: jingfu wang <jingfu.j.wang@ibm.com>
@GeekArthur
Copy link
Contributor Author

@l0rd @sleshchenko @johnmcollier @elsony @amisevsk Thanks for reviewing this PR, comments addressed, can you please review it again?

Copy link
Contributor

@elsony elsony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: elsony, GeekArthur, johnmcollier
To complete the pull request process, please assign after the PR has been reviewed.
You can assign the PR to them by writing /assign in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@GeekArthur GeekArthur merged commit 23ef66d into devfile:master Jan 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation Improvements or additions to documentation lgtm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants