Skip to content

WIP: Enable Multi-Arch Building and Pushing for registry viewer #124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 8 commits into from

Conversation

Jdubrick
Copy link
Contributor

What does this PR do / why we need it

Updates CI to allow for the registry viewer to be built for multiple architectures. A list of changes are explained below:

  • Added scripts/build_multi_arch.sh which allows for the registry viewer to be built and pushed for multiple architectures. This script also supports both podman and docker so we are free to use whatever engine is available. Currently we are using docker as part of the github actions where this script is being called.
  • Added github action setups for both qemu and docker buildx to ci.yaml and pushimage-next.yaml to support the building of multi-arch images.
  • Added a new timeout value to our main Dockerfile so that Yarn install will not timeout prematurely. When building for a different architecture the emulation can be slow and Yarn was timing out before completion.
  • Previously the landing-page and registry-viewer apps were calling a docker-build command as part of our CI to check the builds. I altered these commands to now build a multi-arch image.

Which issue(s) does this PR fix

fixes devfile/api#1548

PR acceptance criteria

  • Unit Tests
  • E2E Tests
  • Documentation
    Update the sidebar if there is a new file added or an existing filename is changed

How to test changes / Special notes to the reviewer

Jdubrick added 7 commits May 30, 2024 10:09
Signed-off-by: Jordan Dubrick <jdubrick@redhat.com>
Signed-off-by: Jordan Dubrick <jdubrick@redhat.com>
Signed-off-by: Jordan Dubrick <jdubrick@redhat.com>
Signed-off-by: Jordan Dubrick <jdubrick@redhat.com>
Signed-off-by: Jordan Dubrick <jdubrick@redhat.com>
Signed-off-by: Jordan Dubrick <jdubrick@redhat.com>
Signed-off-by: Jordan Dubrick <jdubrick@redhat.com>
Copy link

openshift-ci bot commented May 30, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Jdubrick

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Jdubrick
Copy link
Contributor Author

Changing to wip - Need to figure out why the context is randomly being cancelled in this workflow but not on my forked workflows.

@Jdubrick Jdubrick changed the title Enable Multi-Arch Building and Pushing for registry viewer WIP: Enable Multi-Arch Building and Pushing for registry viewer May 30, 2024
Signed-off-by: Jordan Dubrick <jdubrick@redhat.com>
@Jdubrick
Copy link
Contributor Author

Closing this PR, I need to test it locally against my own fork and reopen a PR.

@Jdubrick Jdubrick closed this May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement multi-arch image building for registry-viewer
1 participant