DevTools Week 09/22: Docs Update - Devfile Registry #36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 133d0bd. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 5 targetsSent with 💌 from NxCloud. |
michael-valdron
changed the title
michael-valdron
force-pushed
the
docs-revision
branch
from
025a9c6 to
83baf23
Compare
michael-valdron
force-pushed
the
docs-revision
branch
from
83baf23 to
4721bd3
Compare
michael-valdron
force-pushed
the
docs-revision
branch
from
4721bd3 to
9041f60
Compare
michael-valdron
force-pushed
the
docs-revision
branch
2 times, most recently
from
d3546ce to
7a00eb4
Compare
kim-tsao
reviewed
Nov 28, 2022
libs/docs/src/docs/no-version/building-a-custom-devfile-registry.md
Outdated
Show resolved
Hide resolved
michael-valdron
changed the title
michael-valdron
force-pushed
the
docs-revision
branch
from
7a00eb4 to
4009529
Compare
mike-hoang
reviewed
Mar 31, 2023
libs/docs/src/docs/no-version/building-a-custom-devfile-registry.md
Outdated
Show resolved
Hide resolved
mike-hoang
approved these changes
Mar 31, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: michael-valdron, mike-hoang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
- golang version updated - air gap environment manual added as additional resource Signed-off-by: Michael Valdron <mvaldron@redhat.com>
Signed-off-by: Michael Valdron <mvaldron@redhat.com>
…egistry on Kubernetes cluster formatting fixed. Signed-off-by: Michael Valdron <mvaldron@redhat.com>
- Modify devfile verification step heading fixed - Colon at the end of modify devfile overview paragraph replace with period Signed-off-by: Michael Valdron <mvaldron@redhat.com>
Signed-off-by: Michael Valdron <mvaldron@redhat.com>
Signed-off-by: Michael Valdron <mvaldron@redhat.com>
Signed-off-by: Michael Valdron <mvaldron@redhat.com>
Signed-off-by: Michael Valdron <mvaldron@redhat.com>
michael-valdron
force-pushed
the
docs-revision
branch
from
6db4724 to
133d0bd
Compare
|
New changes are detected. LGTM label has been removed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do / why we need it:
Revisions done for the Devfile Registry section of the doc pages.
Changes
Dockerfileinstruction updatedstack.yaml example header fixedTaken care of in fix devfile stack filename #59Which issue(s) this PR fixes:
Fixes #?
fixes devfile/api#1090
PR acceptance criteria:
How to test changes / Special notes to the reviewer: