-
Notifications
You must be signed in to change notification settings - Fork 27
reorganizing docs navigation for 2.2.0 and 2.2.1 #86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 112f19d. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 5 targetsSent with 💌 from NxCloud. |
1bdda57
to
cd84c3d
Compare
@@ -45,6 +45,7 @@ export const footerNavigation: FooterNavigation = { | |||
{ name: 'Cloud Native Computing Foundation', href: 'https://www.cncf.io' }, | |||
{ name: 'Registry', href: '/' }, | |||
{ name: 'Documentation', href: `https://devfile.io/docs/${defaultVersion}/what-is-a-devfile` }, | |||
{ name: 'Community', href: `https://devfile.io/docs/${defaultVersion}/community` }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have one change request, a side from that everything else looks good.
Signed-off-by: Michael Hoang <mike.s.hoang@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: michael-valdron, mike-hoang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What does this PR do / why we need it
Reorganized the sidebar navigation for 2.2.0 and 2.2.1-alpha with a focus on
all persona docs removed – can add to landing page insteadWhich issue(s) does this PR fix
Fixes devfile/api#1079
PR acceptance criteria
Update the sidebar if there is a new file added or an existing filename is changed
How to test changes / Special notes to the reviewer