Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workspace routings objects name #161

Closed
benoitf opened this issue Sep 29, 2020 · 2 comments · Fixed by #297
Closed

workspace routings objects name #161

benoitf opened this issue Sep 29, 2020 · 2 comments · Fixed by #297
Assignees
Labels
sprint/current Is assigned to issues which are planned to work on in the current team sprint
Milestone

Comments

@benoitf
Copy link
Collaborator

benoitf commented Sep 29, 2020

Is your enhancement related to a problem? Please describe.

workspaces resources are available with devworkspaces
but workspace routings are with workspaceroutings

Describe the solution you'd like

if instead of using Workspace we use DevWorkspace
we should have WorkspaceRoutings renamed to DevWorkspaceRoutings

@amisevsk
Copy link
Collaborator

I don't think it matters too much what internal bookkeeping structs are called, but at this point it's hard to change names since they're used in the web terminal operator.

@benoitf
Copy link
Collaborator Author

benoitf commented Feb 2, 2021

can be filtered using

$ kubectl get WorkspaceRoutings --all-namespaces --selector="controller.devfile.io/workspace_id=<id>"

@sleshchenko sleshchenko added this to the v0.2.0 milestone Mar 2, 2021
@sleshchenko sleshchenko self-assigned this Mar 5, 2021
@sleshchenko sleshchenko added the sprint/current Is assigned to issues which are planned to work on in the current team sprint label Mar 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sprint/current Is assigned to issues which are planned to work on in the current team sprint
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants