This repository has been archived by the owner on Apr 4, 2023. It is now read-only.
feat(devworkspace): Use new name for workspaceRouting: DevWorkspaceRouting #1034
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uting Change-Id: Id032a090c93ada7244e1738725e3482a239c29b4 Signed-off-by: Florent Benoit <fbenoit@redhat.com>
|
✅ E2E Happy path tests succeed 🎉
See Details
Tested with Eclipse Che Single User on K8S (minikube v1.1.1)
|
benoitf
requested review from
azatsarynnyy,
RomanNikitenko and
vzhukovs
as code owners
azatsarynnyy
approved these changes
Mar 17, 2021
amisevsk
approved these changes
Mar 17, 2021
Codecov Report
@@ Coverage Diff @@
## master #1034 +/- ##
=======================================
Coverage 20.80% 20.80%
=======================================
Files 302 302
Lines 11234 11234
Branches 1703 1703
=======================================
Hits 2337 2337
Misses 8747 8747
Partials 150 150 Continue to review full report at Codecov.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Use new DevWorkspaceRouting objects
Screenshot/screencast of this PR
What issues does this PR fix or reference?
devfile/devworkspace-operator#161
How to test this PR?
Use this image
quay.io/crw_pr/che-theia:1034with current DevWorkspaceOperatorPR Checklist
As the author of this Pull Request I made sure that:
What issues does this PR fix or referenceandHow to test this PRcompletedReviewers
Reviewers, please comment how you tested the PR when approving it.
Happy Path Channel
HAPPY_PATH_CHANNEL=next
Change-Id: Id032a090c93ada7244e1738725e3482a239c29b4
Signed-off-by: Florent Benoit fbenoit@redhat.com