Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automounted git-credentials can collide with manually defined gitconfig #744

Closed
Tracked by #21091 ...
amisevsk opened this issue Jan 17, 2022 · 0 comments · Fixed by #786
Closed
Tracked by #21091 ...

Automounted git-credentials can collide with manually defined gitconfig #744

amisevsk opened this issue Jan 17, 2022 · 0 comments · Fixed by #786
Assignees
Milestone

Comments

@amisevsk
Copy link
Collaborator

Description

When using git credentials in a namespace, the DevWorkspace Operator will mount a specifically-created gitconfig to /etc/gitconfig (in order for it to be the config for all containers).

However, this will collide with any manually created gitconfigs the user may create (e.g. in the flow from #710), resulting in workspaces failing to start.

How To Reproduce

  1. Create a secret as in Add automount subpaths option #710, and a git-credentials secret.
  2. Start a DevWorkspace

Expected behavior

We should consider either merging the two gitconfigs or working around the incompatibility in another way.

Additional context

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant