Migrate to Go modules #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sergii Leshchenko <sleshche@redhat.com>
Signed-off-by: Sergii Leshchenko <sleshche@redhat.com>
It's described in version upgrading guide https://github.com/operator-framework/operator-sdk/blob/master/doc/migration/version-upgrade-guide.md#v09x Signed-off-by: Sergii Leshchenko <sleshche@redhat.com>
Signed-off-by: Sergii Leshchenko <sleshche@redhat.com>
amisevsk
reviewed
Jan 14, 2020
There was a problem hiding this comment.
Generally LGTM, but I get a build failure:
go: github.com/openshift/api@v3.9.1-0.20190424152011-77b8897ec79a+incompatible: invalid pseudo-version: preceding tag (v3.9.0) not found
With version
operator-sdk version: "v0.14.0", commit: "4fb185b9d45682473b4951c9788f845ba2fa5b12", go version: "go1.13.3 linux/amd64"
It's strange. It works for me with the specified go and operator-framework versions and even after |
2 tasks
I figured out this issue, and left a comment on the other PR: #5 (comment) |
JPinkney
pushed a commit
to JPinkney/che-workspace-operator
that referenced
this pull request
May 13, 2021
Add a debug target to the make file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR replaces Go Dep dependency management with newer approach Go Modules.
It also updates operator-framework to v0.9.0(the minimal buildable version that is compatible with modules).
v0.8.0 fails to compile with the following error message:
cannot find module providing package github.com/appscode/jsonpatchHow is this PR tested?