Deploy registry only if needed

[JPinkney]

What does this PR do?

This PR creates an internal registry that holds the cloud shell meta. This makes it so that you won't have to deploy the plugin registry when just using cloud shell.

What issues does this PR fix or reference?

eclipse-che/che#16313

Is it tested? How?

Tested on crc with first setting env variable REGISTRY_ENABLED = false. As expected, the plugin registry wasn't deployed and when launching a cloud shell workspace it pulled from the internal registry and successfully started. When you try and start a workspace that uses theia, you will get an error saying something like could not retrieve meta.yaml from registry

Then I turned on REGISTRY_ENABLED = true and ran make deploy and the plugin registry was successfully deployed. Tried to start a cloud shell workspace and it worked. Then I tried to start python-sample.yaml and it worked

[amisevsk]

I put a json.MarshalIndent on the plugin meta we get from utils.GetPluginMeta and I see (formatted as yaml)

apiVersion: v2
spec:
  endpoints:
  - name: cloud-shell
    public: true
    targetPort: 4444
    attributes:
      cookiesAuthEnabled: "true"
      discoverable: "false"
      protocol: http
      secure: "true"
      type: ide
  containers:
  - name: che-machine-exec
    image: quay.io/eclipse/che-machine-exec:nightly
    env: []
    commands: []
    volumes: []
    ports:
    - exposedPort: 4444
    mountSources: false
    command: []
    args: []
  initContainers: []
  workspaceEnv: []
  extensions: []
id: eclipse/cloud-shell/nightly
name: cloud-shell
displayName: Cloud Shell Editor
publisher: eclipse
type: Che Editor
description: Cloud Shell provides an ability to use terminal widget like an editor.
version: nightly
title: Cloud Shell Editor
icon: https://www.eclipse.org/che/images/logo-eclipseche.svg

[amisevsk]

The command in your meta.yaml was added in eclipse-che/che-plugin-registry@74fcb49, which is not included in the 7.8.0 release of the registry. I don't know if it matters significantly, but this does bring up the issue of how we maintain the offline registry (we can discuss in a separate issue)

[amisevsk]

The command actually prevents machine-exec from listening outside the local network, which means cloud shell won't work with basic routing. It's not an issue for openshift-oauth as the proxy pod is included in the deployment and forwards requests.

Created issue eclipse-che/che#16568 to discuss this.

[sleshchenko]

Probably we also may need some endpoint diagnostics tools in workspace controller, like now with nightly plugin registry we'll get Running but not working workspace

[amisevsk]

Tested cloud shell with basic routing and openshift-oauth + webhooks on crc, and it works great.

LGTM

[sleshchenko]

Good job!

I think it's better to have internal plugin registries configuration as external files but I'm OK with addressing it in a separate PR since merging this PR would make my life easier with customizing machine-exec image to my built version)

[amisevsk]

Continues to LGTM

Edit: mean this review to be an "approve"