Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check edge cases for automounted configmaps/secrets #495

Merged
merged 6 commits into from
Jul 27, 2021
Merged

Check edge cases for automounted configmaps/secrets #495

merged 6 commits into from
Jul 27, 2021

Commits on Jul 15, 2021

  1. Move secret/configmap automount code to separate file 

    Move functions related to automounting configmaps and secrets to a
separate file to make reading deployment.go easier.

Signed-off-by: Angel Misevski <amisevsk@redhat.com>
    @amisevsk
    amisevsk committed Jul 15, 2021
    Configuration menu
    Copy the full SHA
    bf248b6 View commit details
    Browse the repository at this point in the history

  2. Fail workspace startup if deployment is invalid 

    Signed-off-by: Angel Misevski <amisevsk@redhat.com>
    @amisevsk
    amisevsk committed Jul 15, 2021
    Configuration menu
    Copy the full SHA
    d0db49c View commit details
    Browse the repository at this point in the history

  3. Check edge cases in automounting volumes and configmaps 

    Check edge cases in automount that can result in collisions:
1. automounted volumes collide on name
2. automounted volumes collide on mountPath
3. devworkspace volumes collide with automounted volume on name
4. devworkspace volume mountPath in a container collides with
   automounted volume's mountPath

Signed-off-by: Angel Misevski <amisevsk@redhat.com>
    @amisevsk
    amisevsk committed Jul 15, 2021
    Configuration menu
    Copy the full SHA
    6fe3c8e View commit details
    Browse the repository at this point in the history

  4. Prefix automounted configmaps and secrets to avoid name collisions 

    Prefix automounted configmaps and secrets with
"automount-[secret|configmap]" to avoid collisions with volumes defined
on DevWorkspaces.

Signed-off-by: Angel Misevski <amisevsk@redhat.com>
    @amisevsk
    amisevsk committed Jul 15, 2021
    Configuration menu
    Copy the full SHA
    0c843e6 View commit details
    Browse the repository at this point in the history

Commits on Jul 23, 2021

  1. Add test cases to cover edge cases in automounted volumes 

    Signed-off-by: Angel Misevski <amisevsk@redhat.com>
    @amisevsk
    amisevsk committed Jul 23, 2021
    Configuration menu
    Copy the full SHA
    5ecedec View commit details
    Browse the repository at this point in the history

Commits on Jul 26, 2021

  1. Improve error messages when automounted volumes collide 

    Signed-off-by: Angel Misevski <amisevsk@redhat.com>
    @amisevsk
    amisevsk committed Jul 26, 2021
    Configuration menu
    Copy the full SHA
    1a7e714 View commit details
    Browse the repository at this point in the history