Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pie chart for DevWorkspace startup failure reasons #663

Merged
merged 1 commit into from
Nov 3, 2021

Conversation

dkwon17
Copy link
Collaborator

@dkwon17 dkwon17 commented Oct 28, 2021

Signed-off-by: David Kwon dakwon@redhat.com

What does this PR do?

Adds a pie chart for DevWorkspace startup failures, where each failure reason is its own category:
image
image

What issues does this PR fix or reference?

eclipse-che/che#20661

Is it tested? How?

To test:

  1. Follow these steps to run Prometheus and Grafana locally: https://github.com/devfile/devworkspace-operator/tree/main/doc/grafana#testing-devworkspace-operator-metrics-locally.
  2. Import the dashboard (grafana-dashboard.json) in Grafana.
  3. Run make install to install the controller.
  4. Create failing DevWorkspace CR instances (for example, change image urls to non-existent ones in https://github.com/devfile/devworkspace-operator/blob/main/samples/flattened_theia-next.yaml) to increment the devworkspace_fail_total Prometheus counter
  5. View the pie chart in the dashboard imported from step 2.

PR Checklist

  • E2E tests pass (when PR is ready, comment /test v8-devworkspace-operator-e2e, v8-che-happy-path to trigger)
    • v8-devworkspace-operator-e2e: DevWorkspace e2e test
    • v8-che-happy-path: Happy path for verification integration with Che

Copy link
Collaborator

@amisevsk amisevsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM apart from the trailing newline Ilya mentioned.

@amisevsk
Copy link
Collaborator

/test v8-devworkspace-operator-e2e, v8-che-happy-path

@dkwon17
Copy link
Collaborator Author

dkwon17 commented Oct 29, 2021

Thank you everyone, I have pushed the change.

@openshift-ci
Copy link

openshift-ci bot commented Oct 30, 2021

@ibuziuk: changing LGTM is restricted to collaborators

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link

openshift-ci bot commented Oct 30, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: amisevsk, dkwon17, ibuziuk, JPinkney

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@amisevsk
Copy link
Collaborator

amisevsk commented Nov 1, 2021

/ok-to-test
/test v8-devworkspace-operator-e2e, v8-che-happy-path
/lgtm

…tup failures

Signed-off-by: David Kwon <dakwon@redhat.com>
@openshift-ci
Copy link

openshift-ci bot commented Nov 2, 2021

New changes are detected. LGTM label has been removed.

@openshift-ci openshift-ci bot removed the lgtm label Nov 2, 2021
@dkwon17
Copy link
Collaborator Author

dkwon17 commented Nov 2, 2021

Updated the commit message to satisfy the Semantic Pull Request check

@amisevsk
Copy link
Collaborator

amisevsk commented Nov 2, 2021

/test v8-devworkspace-operator-e2e, v8-che-happy-path

@openshift-ci
Copy link

openshift-ci bot commented Nov 2, 2021

@dkwon17: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/v8-che-happy-path 50ddf6d link true /test v8-che-happy-path

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@amisevsk amisevsk merged commit 34881f4 into devfile:main Nov 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants