-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pie chart for DevWorkspace startup failure reasons #663
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM apart from the trailing newline Ilya mentioned.
/test v8-devworkspace-operator-e2e, v8-che-happy-path |
Thank you everyone, I have pushed the change. |
@ibuziuk: changing LGTM is restricted to collaborators In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: amisevsk, dkwon17, ibuziuk, JPinkney The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/ok-to-test |
…tup failures Signed-off-by: David Kwon <dakwon@redhat.com>
New changes are detected. LGTM label has been removed. |
Updated the commit message to satisfy the |
/test v8-devworkspace-operator-e2e, v8-che-happy-path |
@dkwon17: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Signed-off-by: David Kwon dakwon@redhat.com
What does this PR do?
Adds a pie chart for DevWorkspace startup failures, where each failure
reason
is its own category:What issues does this PR fix or reference?
eclipse-che/che#20661
Is it tested? How?
To test:
grafana-dashboard.json
) in Grafana.make install
to install the controller.devworkspace_fail_total
Prometheus counterPR Checklist
/test v8-devworkspace-operator-e2e, v8-che-happy-path
to trigger)v8-devworkspace-operator-e2e
: DevWorkspace e2e testv8-che-happy-path
: Happy path for verification integration with Che