Add "patch secrets" to workspace SA RBAC

[amisevsk]

What does this PR do?

Add the patch secrets permission to the default workspace SA RBAC.

What issues does this PR fix or reference?

Required for some use cases that depend on this secret.

Is it tested? How?

PR Checklist

• E2E tests pass (when PR is ready, comment /test v8-devworkspace-operator-e2e, v8-che-happy-path to trigger)
  • v8-devworkspace-operator-e2e: DevWorkspace e2e test
  • v8-che-happy-path: Happy path for verification integration with Che

[JPinkney]

Moving from approved to request changes because I'm not sure if storing everything inside of workspace-credentials-secrets is the right choice in the context of eclipse-che/che#20749. To me, it seems like we should be working with a seperate workspace preferences configmap instead

[amisevsk]

Added workspace-preferences-configmap to the workspace RBAC set 🎉

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: amisevsk, JPinkney

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [JPinkney,amisevsk]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@amisevsk: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/v8-images	2522f13	link	true	/test v8-images

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[vinokurig]

Please do not merge until eclipse-che/che-server#174 is merged. This PR is supposed to add the workspace-preferences-configmap.

[amisevsk]

@vinokurig are you sure there is a blocker for merging this PR? it's purely additive, so merging it shouldn't break anything elsewhere.

Is the concern that the added RBAC may have to be modified? I'm asking because once the Prow issues are resolved, I'd like to begin the v0.11 release process as soon as possible, and I'd like for v0.11 to include these changes (otherwise Theia is waiting for v0.12 in ~5 weeks).

[vinokurig]

@amisevsk
If it depends on the release, then I am OK to go without merging the PR to che-server. The reason why I asked to wait is that the che-server PR contains the logic of creation the workspace-preferences-configmap. I agree that merging it shouldn't break anything elsewhere, so let's merge it.

[amisevsk]

/test v8-devworkspace-operator-e2e