Use BadRequest as failure reason when we can't get containers #680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Treat failures to extract containers/initContainers from a DevWorkspace as a BadRequest failure, as this will typically be due to an issue in the DevWorkspace itself. Signed-off-by: Angel Misevski <amisevsk@redhat.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: amisevsk The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
JPinkney
approved these changes
Nov 22, 2021
|
/test v8-devworkspace-operator-e2e |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Treat failures to extract containers/initContainers from a DevWorkspace as a BadRequest failure, as this will typically be due to an issue in the DevWorkspace itself.
What issues does this PR fix or reference?
Fixes eclipse-che/che#20751
Note this issue is also fixed by devfile/api#685, which will cause workspace start to fail earlier and with a better message.
Is it tested? How?
N/A
PR Checklist
/test v8-devworkspace-operator-e2e, v8-che-happy-pathto trigger)v8-devworkspace-operator-e2e: DevWorkspace e2e testv8-che-happy-path: Happy path for verification integration with Che