Update handling of registryUrls to match expectation from registry.devfile.io #770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When specifying a plugin/parent via registryUrl + id, the devfile spec assumes that the devfile with <id> will be served from <registryUrl>/devfiles/<id> This updates the operator to follow this convention when flattening devfiles. Signed-off-by: Angel Misevski <amisevsk@redhat.com>
Update existing test cases to use the convention that registry devfiles are stored at <registryUrl>/devfiles/<id> Signed-off-by: Angel Misevski <amisevsk@redhat.com>
4 tasks
ibuziuk
approved these changes
Feb 7, 2022
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: amisevsk, ibuziuk The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test v8-devworkspace-operator-e2e |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Update the flatten library to resolve plugins/parents from
<registryUrl>/devfiles/<id>, as this appears to be what's expected in the main devfile registry -- e.g. https://registry.devfile.io/viewer/devfiles/Community+nodejs-basic useswhich refers to the devfile https://registry.devfile.io/devfiles/nodejs
What issues does this PR fix or reference?
N/A
Is it tested? How?
Test cases are updated.
PR Checklist
/test v8-devworkspace-operator-e2e, v8-che-happy-pathto trigger)v8-devworkspace-operator-e2e: DevWorkspace e2e testv8-che-happy-path: Happy path for verification integration with Che