-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add per-user storage-class option #893
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but could you please add some tests
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: amisevsk, AObuchow, ibuziuk The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
New changes are detected. LGTM label has been removed. |
I added a test to ensure that the |
The 'per-user' storage-type is an alternate storage-type name for the 'common' storage-type. In other words, it is an alias for the 'common' storage-type and behaves in the same manner as the 'common' storage-type. Part of eclipse-che/che#21405 Signed-off-by: Andrew Obuchowicz <aobuchow@redhat.com>
Signed-off-by: Andrew Obuchowicz <aobuchow@redhat.com>
6035284
to
a437d4e
Compare
Signed-off-by: Andrew Obuchowicz <aobuchow@redhat.com>
a437d4e
to
b3e96ac
Compare
The 'per-user' storage type is an alternate storage-type name for the 'common' storage class.
In other words, it is an alias for the 'common' storage-type and behaves in the same manner.
Note that in the PR's current state, the 'per-user' storage-type replaces the 'common' storage-type, and the 'common' storage-type is treated as an alias of the 'per-user' storage-type. It may be better to reverse things, i.e. document that the 'per-user' storage-type is an alias of the 'common' storage-type
What issues does this PR fix or reference?
Part of eclipse-che/che#21405
Is it tested? How?
There are two parts of this PR to test.
Ensuring that the 'per-user' storage type works the same as the 'common' storage type:
claim-devworkspace
PVC is created.claim-devworkspace
PVC is deleted.Ensuring that you can switch between the 'per-user' and 'common' storage-type:
kubectl edit
oroc edit
and change their storage-type fromper-user
->common
andcommon
->per-user
respectivelyPR Checklist
/test v8-devworkspace-operator-e2e, v8-che-happy-path
to trigger)v8-devworkspace-operator-e2e
: DevWorkspace e2e testv8-che-happy-path
: Happy path for verification integration with Che