Add basic tests for cloud shell #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: flacatus <flacatus@redhat.com>
|
cc @rhopp |
sleshchenko
reviewed
Jun 3, 2020
There was a problem hiding this comment.
-
I have the following restructure proposal for source code sleshchenko@c8941ab
-
I think we should test command-line-terminal instead of cloud-shell
JPinkney
reviewed
Jun 3, 2020
amisevsk
reviewed
Jun 3, 2020
Signed-off-by: flacatus <flacatus@redhat.com>
Signed-off-by: flacatus <flacatus@redhat.com>
Signed-off-by: flacatus <flacatus@redhat.com>
Signed-off-by: flacatus <flacatus@redhat.com>
Signed-off-by: flacatus <flacatus@redhat.com>
Signed-off-by: flacatus <flacatus@redhat.com>
Signed-off-by: flacatus <flacatus@redhat.com>
sleshchenko
approved these changes
Jun 4, 2020
There was a problem hiding this comment.
Great job!
Please consider applying the minor suggested changes sleshchenko@2256850
And we need to be careful when continuing a program when a fatal error occurs.
Signed-off-by: flacatus <flacatus@redhat.com>
sleshchenko
reviewed
Jun 5, 2020
test/e2e/pkg/client/client.go
Outdated
| kubeClient *kubernetes.Clientset | ||
| } | ||
|
|
||
| // NewCodeReady creates C, a workspaces used to expose common testing functions. |
There was a problem hiding this comment.
Suggested change
| // NewCodeReady creates C, a workspaces used to expose common testing functions. | |
| // NewK8sClient creates kubernetes client wrapper with helper functions and direct access to k8s go client |
sleshchenko
approved these changes
Jun 5, 2020
test/e2e/pkg/client/pod.go
Outdated
| } | ||
| return false, nil | ||
| } | ||
| } |
Signed-off-by: flacatus <flacatus@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: flacatus flacatus@redhat.com
What does this PR do?
This PR contains necessary files to start to use e2e tests for Che-Workspace-operator in Prow CI. The tests includes:
This tests will be part of PROW CI running in latest stable Openshift and nightly version. More info about PROW: https://ci-operator-configresolver-ui-ci.apps.ci.l2s4.p1.openshiftapps.com/ and
https://docs.google.com/document/d/1SQ_qlkcplqhe8h6ONXdgBr7YUVbs4oRSj4ISl3gpLW4/edit
What issues does this PR fix or reference?
eclipse-che/che#16667
Is it tested? How?