fix: Treat Forbidden error as unrecoverable sync error

[tolusha]

Signed-off-by: Anatolii Bazko abazko@redhat.com

What does this PR do?

Treat Forbidden error as unrecoverable sync error

What issues does this PR fix or reference?

eclipse-che/che#21599

Is it tested? How?

1. Create an ResourceQuota in a user namespace

kind: ResourceQuota
apiVersion: v1
metadata:
  name: resourequota
spec:
  hard:
    count/deployments.apps: '1'

2. Try to create a second workspace. Creation immediately fails, dashboard prints an error.

PR Checklist

• E2E tests pass (when PR is ready, comment /test v8-devworkspace-operator-e2e, v8-che-happy-path to trigger)
  • v8-devworkspace-operator-e2e: DevWorkspace e2e test
  • v8-che-happy-path: Happy path for verification integration with Che

[openshift-ci]

Hi @tolusha. Thanks for your PR.

I'm waiting for a devfile member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[AObuchow]

Code looks good to me, tested and works as expected:

[aobuchow@fedora samples]$ kubectl get dw -w -n user-namespace
NAME                       DEVWORKSPACE ID             PHASE     INFO
theia-next                 workspace6445dbdcef594070   Running   https://workspace6445dbdcef594070-theia-3100.192.168.49.2.nip.io/
theia-next-external-dwoc   workspacee121c022ae96494b   Failed    deployments.apps "workspacee121c022ae96494b" is forbidden: exceeded quota: resourequota, requested: count/deployments.apps=1, used: count/deployments.apps=1, limited: count/deployments.apps=1

I will let @amisevsk review and merge it however to get his final input and approval.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: amisevsk, AObuchow, tolusha

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [amisevsk]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

New changes are detected. LGTM label has been removed.

[amisevsk]

/retest

/ok-to-test