added devfile registry content #99

jc-berger · 2021-09-30T16:44:50Z

This registry content is taken from the registry repo: https://github.com/johnmcollier/registry-docs

See the Jira ticket: https://issues.redhat.com/browse/RHDEVDOCS-2570

docs/modules/user-guide/nav.adoc

jc-berger · 2021-09-30T16:48:06Z

@robin-owen, please review, thank you!

kowen-rh

Peer review is still in progress, but I'm leaving my comments so far. I'll pick the review back up tomorrow, @jc-berger.

I'll leave my formal approval/request changes on the final review once it's complete. For now, I'm simply submitting these as comments.

docs/modules/user-guide/pages/building-custom-devfile-registry.adoc

docs/modules/user-guide/pages/deploying-devfile-registry.adoc

docs/modules/user-guide/partials/con_devfile-registry.adoc

docs/modules/user-guide/partials/proc_adding-registry-schema.adoc

docs/modules/user-guide/pages/building-custom-devfile-registry.adoc

docs/modules/user-guide/partials/proc_adding-registry-schema.adoc

johnmcollier

First round of reviews.

I'll finish up tomorrow, but here's some preliminary comments. Thanks again Jake!

docs/modules/user-guide/pages/building-custom-devfile-registry.adoc

docs/modules/user-guide/pages/deploying-devfile-registry.adoc

docs/modules/user-guide/partials/proc_building-devfile-registry.adoc

docs/modules/user-guide/partials/proc_creating-git-repository.adoc

docs/modules/user-guide/partials/proc_deploying-registry-with-olm.adoc

docs/modules/user-guide/partials/proc_tagging-pushing-registry-container-image.adoc

docs/modules/user-guide/partials/con_understanding-a-devfile-registry.adoc

docs/modules/user-guide/partials/proc_building-a-devfile-registry.adoc

docs/modules/user-guide/partials/proc_creating-a-git-repository.adoc

docs/modules/user-guide/partials/proc_tagging-and-pushing-a-registry-container-image.adoc

docs/modules/user-guide/partials/proc_deploying-a-devfile-registry-with-olm.adoc

openshift-ci · 2021-10-13T20:21:19Z

@robin-owen: changing LGTM is restricted to collaborators

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

johnmcollier

Approving from dev side of things. No concerns apart from what Kevin brought up.

jc-berger · 2021-10-15T19:03:15Z

@robin-owen thanks for the awesome, thorough feedback! I've addressed your comments and left some questions.

I'm going to go through the docs again to keep an eye out for file names to monospace--I might have missed some with this round.

Thanks fo all your help thus far on this registry work!

kowen-rh

Missed the file docs/modules/user-guide/partials/proc_adding-a-registry-schema.adoc in previous reviews (oops! GitHub didn't render the diff by default and I skipped right over it) -- correcting that now.

docs/modules/user-guide/partials/proc_adding-a-registry-schema.adoc

openshift-ci · 2021-10-19T18:22:52Z

@robin-owen: changing LGTM is restricted to collaborators

In response to this:

Missed the file docs/modules/user-guide/partials/proc_adding-a-registry-schema.adoc in previous reviews (oops! GitHub didn't render the diff by default and I skipped right over it) -- correcting that now.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

kowen-rh

A few more nitpicks, but overall, this PR looks good to me. 👍

I'll submit approval once these small issues are resolved. :)

docs/modules/user-guide/partials/proc_creating-a-git-repository.adoc

docs/modules/user-guide/partials/proc_deploying-a-devfile-registry-with-helm-chart.adoc

docs/modules/user-guide/partials/proc_deploying-a-devfile-registry-with-olm.adoc

docs/modules/user-guide/partials/proc_tagging-and-pushing-a-registry-container-image.adoc

docs/modules/user-guide/partials/proc_creating-a-git-repository.adoc

kowen-rh

LGTM. 👍

openshift-ci · 2021-10-20T20:55:37Z

@robin-owen: changing LGTM is restricted to collaborators

In response to this:

LGTM. 👍

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

jc-berger · 2021-10-28T21:24:12Z

@rkratky I am now able to build this PR locally! It looks good from my end. The PR is ready for your review and hopefully looks good to merge!

jc-berger · 2021-11-04T15:32:08Z

Made a new commit that includes a link to the registry REST API. Here's how it looks rendered:

johnmcollier · 2021-11-04T15:38:46Z

Looks good, thanks @jc-berger

rkratky

@jc-berger, please, unify the use of folder and directory in the text. Io'd go for the more technical 'directory' (as it's about directories/folders in Git repos), but up to you -- just make it consistent.

docs/modules/user-guide/pages/deploying-a-devfile-registry.adoc

docs/modules/user-guide/partials/proc_building-a-devfile-registry.adoc

docs/modules/user-guide/partials/proc_deploying-a-devfile-registry-with-olm.adoc

docs/modules/user-guide/partials/proc_tagging-and-pushing-a-registry-container-image.adoc

Co-authored-by: Robert Krátký <rkratky@redhat.com> Co-authored-by: Robert Krátký <rkratky@redhat.com> Co-authored-by: Robert Krátký <rkratky@redhat.com> Co-authored-by: Robert Krátký <rkratky@redhat.com> Co-authored-by: Robert Krátký <rkratky@redhat.com> Co-authored-by: Robert Krátký <rkratky@redhat.com> Co-authored-by: Robert Krátký <rkratky@redhat.com> Co-authored-by: Robert Krátký <rkratky@redhat.com> Co-authored-by: Robert Krátký <rkratky@redhat.com> Co-authored-by: Robert Krátký <rkratky@redhat.com> Co-authored-by: Robert Krátký <rkratky@redhat.com> Co-authored-by: Robert Krátký <rkratky@redhat.com> Co-authored-by: Robert Krátký <rkratky@redhat.com> Co-authored-by: Robert Krátký <rkratky@redhat.com> Co-authored-by: Robert Krátký <rkratky@redhat.com> Co-authored-by: Robert Krátký <rkratky@redhat.com> Co-authored-by: Robert Krátký <rkratky@redhat.com> Co-authored-by: Robert Krátký <rkratky@redhat.com> Co-authored-by: Robert Krátký <rkratky@redhat.com> Co-authored-by: Robert Krátký <rkratky@redhat.com> Co-authored-by: Robert Krátký <rkratky@redhat.com> Co-authored-by: Robert Krátký <rkratky@redhat.com> Co-authored-by: Robert Krátký <rkratky@redhat.com> Co-authored-by: Robert Krátký <rkratky@redhat.com> Co-authored-by: Robert Krátký <rkratky@redhat.com> Co-authored-by: Robert Krátký <rkratky@redhat.com> Co-authored-by: Robert Krátký <rkratky@redhat.com> Co-authored-by: Robert Krátký <rkratky@redhat.com>

openshift-ci · 2021-11-08T16:27:23Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jc-berger, johnmcollier, rkratky, robin-owen

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

jc-berger added the documentation Improvements or additions to documentation label Sep 30, 2021

jc-berger self-assigned this Sep 30, 2021

This was referenced Sep 30, 2021

WIP: added more assemblies to include more content on devfile registries #94

Closed

WIP: added docs for building a custom devfile registry #95

Closed

WIP: added docs for deploying devfile registry #96

Closed

WIP: added docs for registry schema #97

Closed

jc-berger commented Sep 30, 2021

View reviewed changes

docs/modules/user-guide/nav.adoc Show resolved Hide resolved

jc-berger changed the title ~~Added devfile registry content~~ WIP: added devfile registry content Sep 30, 2021

openshift-ci bot added the do-not-merge/work-in-progress label Sep 30, 2021

kowen-rh reviewed Sep 30, 2021

View reviewed changes

johnmcollier requested changes Oct 5, 2021

View reviewed changes

openshift-ci bot assigned johnmcollier Oct 5, 2021

kowen-rh suggested changes Oct 13, 2021

View reviewed changes

johnmcollier approved these changes Oct 14, 2021

View reviewed changes

openshift-ci bot added lgtm and removed lgtm labels Oct 14, 2021

kowen-rh suggested changes Oct 19, 2021

View reviewed changes

kowen-rh reviewed Oct 20, 2021

View reviewed changes

kowen-rh approved these changes Oct 20, 2021

View reviewed changes

jc-berger changed the title ~~WIP: added devfile registry content~~ added devfile registry content Nov 1, 2021

openshift-ci bot removed the do-not-merge/work-in-progress label Nov 1, 2021

rkratky requested changes Nov 5, 2021

View reviewed changes

openshift-ci bot assigned rkratky Nov 5, 2021

rkratky approved these changes Nov 8, 2021

View reviewed changes

openshift-ci bot added the lgtm label Nov 8, 2021

rkratky merged commit 262b907 into devfile:master Nov 8, 2021

jc-berger mentioned this pull request Nov 15, 2021

cherry picked registry docs additions for 2.1 #112

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

added devfile registry content #99

added devfile registry content #99

jc-berger commented Sep 30, 2021

jc-berger commented Sep 30, 2021

kowen-rh left a comment

johnmcollier left a comment

openshift-ci bot commented Oct 13, 2021

johnmcollier left a comment

jc-berger commented Oct 15, 2021

kowen-rh left a comment

openshift-ci bot commented Oct 19, 2021

kowen-rh left a comment

kowen-rh left a comment

openshift-ci bot commented Oct 20, 2021

jc-berger commented Oct 28, 2021 •

edited

Loading

jc-berger commented Nov 4, 2021

johnmcollier commented Nov 4, 2021

rkratky left a comment

openshift-ci bot commented Nov 8, 2021

added devfile registry content #99

added devfile registry content #99

Conversation

jc-berger commented Sep 30, 2021

jc-berger commented Sep 30, 2021

kowen-rh left a comment

Choose a reason for hiding this comment

johnmcollier left a comment

Choose a reason for hiding this comment

openshift-ci bot commented Oct 13, 2021

johnmcollier left a comment

Choose a reason for hiding this comment

jc-berger commented Oct 15, 2021

kowen-rh left a comment

Choose a reason for hiding this comment

openshift-ci bot commented Oct 19, 2021

kowen-rh left a comment

Choose a reason for hiding this comment

kowen-rh left a comment

Choose a reason for hiding this comment

openshift-ci bot commented Oct 20, 2021

jc-berger commented Oct 28, 2021 • edited Loading

jc-berger commented Nov 4, 2021

johnmcollier commented Nov 4, 2021

rkratky left a comment

Choose a reason for hiding this comment

openshift-ci bot commented Nov 8, 2021

jc-berger commented Oct 28, 2021 •

edited

Loading