-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
parsing devfile downloads resource files #139
Conversation
Signed-off-by: Michael Hoang <mhoang@redhat.com>
Signed-off-by: Michael Hoang <mhoang@redhat.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR only handles stacks from registry. what about parent reference from a URL? or from a local path (absolute/relative URI)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add more comments, so other prople will have better understanding of the code for future maintenance.
Signed-off-by: Michael Hoang <mhoang@redhat.com>
Codecov ReportBase: 57.67% // Head: 57.72% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #139 +/- ##
==========================================
+ Coverage 57.67% 57.72% +0.05%
==========================================
Files 35 35
Lines 3794 3960 +166
==========================================
+ Hits 2188 2286 +98
- Misses 1485 1537 +52
- Partials 121 137 +16
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Signed-off-by: Michael Hoang <mhoang@redhat.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
look good to me. thanks for the change
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mike-hoang, yangcao77 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Michael Hoang mhoang@redhat.com
What does this PR do?:
Downloads all resources files from a stack to the local root folder if it doesn’t already exist (will not overwrite files).
The resource files will only be downloaded in the following cases:
Which issue(s) this PR fixes:
fixes devfile/api#46
PR acceptance criteria:
Testing and documentation do not need to be complete in order for this PR to be approved. We just need to ensure tracking issues are opened.
Unit/Functional tests
QE Integration test
Documentation
Client Impact
How to test changes / Special notes to the reviewer: