Revert Test Data for odo #72
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Maysun J Faisal <maysunaneek@gmail.com>
yangcao77
approved these changes
Mar 17, 2021
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: maysunfaisal, yangcao77 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
4 tasks
|
Closing, as its better to just move forwards and try to get gomock for mocking rather than reverting. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Maysun J Faisal maysunaneek@gmail.com
What does this PR do?
This PR reverts the Test struct and mock funcs as odo is using them. Pls refer to odo PR comment redhat-developer/odo#4465 (comment) for discussion
we should discuss and think about the possibility of replacing these with go mock in the future since the interface is in devfile/library and the consequences for the consumers of devfile/library
What issues does this PR fix or reference?
reverts back part of the changes made by #62
Is your PR tested? Consider putting some instruction how to test your changes
yes, updated one of the generator tests to use TestDevfileData to ensure all mock func are implemented as previously