-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release branching workflow revisions #57
Release branching workflow revisions #57
Conversation
Signed-off-by: Michael Valdron <mvaldron@redhat.com>
…parameter Signed-off-by: Michael Valdron <mvaldron@redhat.com>
…s VERSION file instead of ref_name Signed-off-by: Michael Valdron <mvaldron@redhat.com>
Signed-off-by: Michael Valdron <mvaldron@redhat.com>
N/A |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #57 +/- ##
=======================================
Coverage 26.43% 26.43%
=======================================
Files 25 25
Lines 1415 1415
=======================================
Hits 374 374
Misses 1020 1020
Partials 21 21 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: michael-valdron, thepetk The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* release branching PR workflow Signed-off-by: Michael Valdron <mvaldron@redhat.com> * check version uses VERSION file as base, no longer takes ref_name as parameter Signed-off-by: Michael Valdron <mvaldron@redhat.com> * registry operator built image for release integration testing now uses VERSION file instead of ref_name Signed-off-by: Michael Valdron <mvaldron@redhat.com> * revert docker/build-push-action to v1.1.x Signed-off-by: Michael Valdron <mvaldron@redhat.com> --------- Signed-off-by: Michael Valdron <mvaldron@redhat.com> Signed-off-by: thepetk <thepetk@gmail.com>
Please specify the area for this PR
registry operator
What does does this PR do / why we need it:
These changes are part of revisions to #56 changes to merge release changes to a release branch before creating the release: devfile/api#1267 (comment)
In addition, one of these changes reverts
docker/build-push-action
tov1.1.2
the latestv1.1.x
version which fixes the silent failures when pushing container images (devfile/api#1328).Which issue(s) this PR fixes:
Fixes #?
fixes part of devfile/api#1267
fixes devfile/api#1328
PR acceptance criteria:
Documentation
How to test changes / Special notes to the reviewer: