Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update license header file to use the year 2023 #155

Merged
merged 1 commit into from
Jan 20, 2023

Conversation

michael-valdron
Copy link
Member

Signed-off-by: Michael Valdron mvaldron@redhat.com

Please specify the area for this PR

What does does this PR do / why we need it:

Updates license headers to 2023

Which issue(s) this PR fixes:

Fixes #?

devfile/api#1004

PR acceptance criteria:

  • Test Coverage
    • Are your changes sufficiently tested, and are any applicable test cases added or updated to cover your changes?

Documentation (WIP)

How to test changes / Special notes to the reviewer:

@codecov
Copy link

codecov bot commented Jan 10, 2023

Codecov Report

Base: 43.92% // Head: 43.20% // Decreases project coverage by -0.73% ⚠️

Coverage data is based on head (d94ae58) compared to base (7a809c0).
Patch has no changes to coverable lines.

❗ Current head d94ae58 differs from pull request most recent head 9696064. Consider uploading reports for the commit 9696064 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #155      +/-   ##
==========================================
- Coverage   43.92%   43.20%   -0.73%     
==========================================
  Files           6        6              
  Lines        1020     1037      +17     
==========================================
  Hits          448      448              
- Misses        530      546      +16     
- Partials       42       43       +1     
Impacted Files Coverage Δ
index/server/pkg/server/endpoint.go 35.51% <0.00%> (-1.28%) ⬇️
index/server/pkg/server/index.go 9.02% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@kim-tsao kim-tsao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@michael-valdron thanks for looking at this so quickly. I should have clarified in my issue that the requested changes are for the https://github.com/devfile/registry-support/blob/main/license_header.txt. This ensures the header gets added to new files for the current year.

The rules for updating existing files are:

  • If there are no changes, then no need to update
  • If file has changes, then we need to update in the format [original year]-[year in which the file was updated]

I'll update the issue with these details

@michael-valdron michael-valdron changed the title Update license headers to 2023 Update license header file to use year range Jan 19, 2023
Copy link
Contributor

@kim-tsao kim-tsao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, this should be just the year 2023 since it only gets applied to new files

@michael-valdron michael-valdron changed the title Update license header file to use year range Update license header file to use the year 2023 Jan 19, 2023
Signed-off-by: Michael Valdron <mvaldron@redhat.com>
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 19, 2023
@openshift-ci
Copy link

openshift-ci bot commented Jan 19, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kim-tsao, michael-valdron
Once this PR has been reviewed and has the lgtm label, please assign johnmcollier for approval by writing /assign @johnmcollier in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@michael-valdron michael-valdron merged commit fc7db94 into devfile:main Jan 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants