Add odo v3 tests and break validation tests into separate jobs #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tomas Kral <tkral@redhat.com>
Signed-off-by: Tomas Kral <tkral@redhat.com>
Signed-off-by: Tomas Kral <tkral@redhat.com>
kadel
requested review from
johnmcollier
and removed request for
maxandersen and
christoph-jerolimov
kadel
force-pushed
the
add-odov3-tests
branch
from
84ecd8d
to
fcd351e
Compare
kadel
changed the title
Signed-off-by: Tomas Kral <tkral@redhat.com>
kadel
force-pushed
the
add-odov3-tests
branch
from
fcd351e
to
e6e91bd
Compare
kadel
changed the title
|
/retest |
johnmcollier
approved these changes
Oct 4, 2022
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: johnmcollier, kadel The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@johnmcollier, who can merge this? |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?:
Add new tests that validate that all devfiles and all starter projects are working with odo.
Currently, there are a few skipped tests:
I'm going to test each failed scenario manually to determine the cause of the failure.
Some failures are due to the starter project not being able to start without additional code.
Some failures will be due to the test not being able to correctly detect the application is running.
I'll address all issues in separate PRs.
I would like to get this PR merged so we can be sure that we are not breaking the stacks currently working.
This PR also breaks check_nonterminating check_odov2 and check_odov3 tests into jobs, so they are executed parallelly, and we have quicker feedback on the PRs.
Which issue(s) this PR fixes:
PR acceptance criteria:
Have you read the devfile registry contributing guide and followed its instructions?
Does this repository's tests pass with your changes?
Does any documentation need to be updated with your changes?
Have you tested the changes with existing tools, i.e. Odo, Che, Console? (See devfile registry contributing guide on how to test changes)
How to test changes / Special notes to the reviewer: