Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating java-wildfly deploy.yaml now that #203

Closed
wants to merge 1 commit into from

Conversation

ehsavoie
Copy link
Collaborator

@ehsavoie ehsavoie commented Sep 5, 2023

devfile/api#1049 has been fixed

What does this PR do?:

Udate the deploy.yaml to use proper 8080 port since we don't need the workaround issue 1049 anymore.

PR acceptance criteria:

  • Contributing guide
    Have you read the devfile registry contributing guide and followed its instructions?
  • Test automation
    Does this repository's tests pass with your changes?
  • Documentation
    Does any documentation need to be updated with your changes?
  • Check Tools Provider
    Have you tested the changes with existing tools, i.e. Odo, Che, Console? (See devfile registry contributing guide on how to test changes)

How to test changes / Special notes to the reviewer:

@openshift-ci
Copy link

openshift-ci bot commented Sep 5, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ehsavoie
Once this PR has been reviewed and has the lgtm label, please assign kim-tsao for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

devfile/api#1049 has been fixed

Signed-off-by: Emmanuel Hugonnet <ehugonne@redhat.com>
@openshift-ci
Copy link

openshift-ci bot commented Sep 5, 2023

@ehsavoie: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/v4.12-images 27b9262 link true /test v4.12-images
ci/prow/v4.12-registry-test 27b9262 link true /test v4.12-registry-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ehsavoie
Copy link
Collaborator Author

ehsavoie commented Sep 5, 2023

hum those files are working with odo 3.14 and are valid since the devfile validation tool fix

@ehsavoie
Copy link
Collaborator Author

ehsavoie commented Sep 8, 2023

The issue still affects DevSpaces

@ehsavoie ehsavoie closed this Sep 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant