Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.0 #138

Merged
merged 193 commits into from
May 7, 2019
Merged

v1.0 #138

merged 193 commits into from
May 7, 2019

Conversation

brunolemos
Copy link
Member

@brunolemos brunolemos commented May 7, 2019

➡️ https://beta.devhubapp.com/ | Join our Slack Community

v1.0

  • New design with cleaner card layout
  • Improve filters UX

devhub

  • New layout option: Single-column

    single-column-view-mode

  • New column type: Issues & PRs

  • New filters:

    • State (open/closed/merged)
    • Draft
    • Subject Type
    • Event Actions
  • Make keyboard usage faster and with better Tab support

  • Improve performance considerably

Next (help needed)

DevHub is an open source project and I would love to get code-related contributions! Here's some important ones that you could help:

Because it is a horizontal single-line layout, doesnt work well on small screens
Caused by the olderDate comparison

Closes #29 (but there are other edge bugs, e.g. caused by the pagination using page and per_page, which is broking when new content show up while you are paginating)
Now goes in circle between states (B->C->A->B) instead of B->C->B->A->B
For example, card icon now shows at the left.

Also the avatar is now small.
Including existing users (still not sure about this decision but lets see. I want all to experiment this new layout and they can change back manually)
Better wait for them to change it manually
This reverts commit 82a4ae2.

Yes I am very indecisive sometimes
@brunolemos brunolemos added this to the v1.0 milestone May 7, 2019
@brunolemos brunolemos self-assigned this May 7, 2019
@brunolemos brunolemos merged commit caee869 into master May 7, 2019
@brunolemos
Copy link
Member Author

This pull request introduces 21 alerts and fixes 2 when merging ef22c96 into 43a4672 - view on LGTM.com

new alerts:

  • 18 for Useless conditional
  • 2 for Identical operands
  • 1 for Unreachable statement

fixed alerts:

  • 2 for Unneeded defensive code

Comment posted by LGTM.com

brunolemos added a commit that referenced this pull request May 7, 2019
@brunolemos brunolemos deleted the v1 branch May 10, 2019 22:58
@brunolemos brunolemos modified the milestones: v1.0, v0.80.0 Jun 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant