Development #33
Merged
Development #33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HTTP api transport improvement
Autoupdate session
Merisho
reviewed
Feb 27, 2018
| Promise.all([httpDeviceHive.configuration.get(testConfigurations[0].name), wsDeviceHive.configuration.get(testConfigurations[1].name)]) | ||
| .then(dataAll => { | ||
| for (const key in dataAll) { | ||
| assert.isObject(dataAll[key]) |
Merisho
reviewed
Feb 27, 2018
| .then(dataAll => { | ||
| for (const key in dataAll) { | ||
| assert.isObject(dataAll[key]) | ||
| assert.include(dataAll[key], testConfigurations[key]); |
There was a problem hiding this comment.
Also try to use constants as expected values to make assertion more clear
Merisho
reviewed
Feb 27, 2018
| }); | ||
|
|
||
|
|
||
| it('DeviceCommandAPI.insert()', done => { |
There was a problem hiding this comment.
Please specify in test name what method (DeviceCommandAPI.insert()) should do/return
Merisho
reviewed
Feb 27, 2018
| }); | ||
|
|
||
|
|
||
| it('DeviceCommandAPI.wait()', done => { |
There was a problem hiding this comment.
You can omit second argument of it() and leave only test name so mocha will mark it as TODO for you
Merisho
reviewed
Feb 27, 2018
| @@ -40,7 +40,8 @@ describe('TokenAPI WS', () => { | |||
| deviceHive = new DeviceHive({ | |||
| login: `dhadmin`, | |||
There was a problem hiding this comment.
We can move test configuration for connection in separate file to reuse in each test
There was a problem hiding this comment.
This configuration is related to some stub servers in tests, so, from my perspective it would be better to leave connection configuration in the same file as stubs configuration, until stubs would be reworked.
Integration tests improvements
Integration tests improvements
Merisho
approved these changes
Mar 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unit tests
Integration tests
Autoupdating session
Slight code improvements