Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add property to determine if device is compatible with Apple Pencil #179

Merged
merged 4 commits into from
Apr 12, 2019
Merged

Add property to determine if device is compatible with Apple Pencil #179

merged 4 commits into from
Apr 12, 2019

Conversation

SomeRandomiOSDev
Copy link
Contributor

Added a property to the Device enum to determine is the given device can use the Apple Pencil and which version of the Apple Pencil is supported. Current list of supported devices taken off of the Apple Pencil support page: https://support.apple.com/en-us/HT205236

@devicekit-danger-bot
Copy link

devicekit-danger-bot commented Apr 11, 2019

4 Warnings
⚠️ Plist changed, don’t forget to localize your plist values
⚠️ Source/Device.generated.swift#L618 - Prefer non-optional booleans over optional booleans.
⚠️ Source/Device.generated.swift#L620 - TODOs should be resolved (Longterm we need a better solu…).
⚠️ Source/Device.generated.swift#L1171 - Prefer empty collection over optional collection.

SwiftLint found issues

Warnings

File Line Reason
Device.generated.swift 618 Prefer non-optional booleans over optional booleans.
Device.generated.swift 1171 Prefer empty collection over optional collection.
Device.generated.swift 620 TODOs should be resolved (Longterm we need a better solu...).

Generated by 🚫 Danger

Source/Device.generated.swift Outdated Show resolved Hide resolved
@denisenepraunig denisenepraunig merged commit 494d13a into devicekit:master Apr 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants