Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 3D Touch and Force Touch support variables #183

Merged
merged 3 commits into from
May 2, 2019
Merged

Conversation

Zandor300
Copy link
Member

@Zandor300 Zandor300 commented Apr 29, 2019

As suggested in #182, this pull request adds the following variables for determining of the device has support for 3D Touch (iOS) or Force Touch (watchOS):

iOS

  • allDevicesWith3dTouchSupport
  • has3dTouchSupport

watchOS

  • allWatchesWithForceTouchSupport
  • hasForceTouchSupport

#182 should remain open since there is talk about macOS support. We've been thinking about this and I've created an issue for it: #184

@devicekit-danger-bot
Copy link

devicekit-danger-bot commented Apr 29, 2019

4 Warnings
⚠️ Plist changed, don’t forget to localize your plist values
⚠️ Source/Device.generated.swift#L618 - Prefer non-optional booleans over optional booleans.
⚠️ Source/Device.generated.swift#L620 - TODOs should be resolved (Longterm we need a better solu…).
⚠️ Source/Device.generated.swift#L1191 - Prefer empty collection over optional collection.

SwiftLint found issues

Warnings

File Line Reason
Device.generated.swift 618 Prefer non-optional booleans over optional booleans.
Device.generated.swift 1191 Prefer empty collection over optional collection.
Device.generated.swift 620 TODOs should be resolved (Longterm we need a better solu...).

Generated by 🚫 Danger

@denisenepraunig denisenepraunig merged commit bfb37a2 into master May 2, 2019
@Zandor300 Zandor300 deleted the 3d-touch branch May 27, 2019 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants