Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add variables to check which cameras a device has #188

Merged
merged 4 commits into from
May 31, 2019

Conversation

Zandor300
Copy link
Member

Fixes #186

New features

  • New .cameras variable to get an array of CameraTypes the device features.
  • New .allDevicesWithCamera, .allDevicesWithNormalCamera and .allDevicesWithTelephotoCamera variables.
  • New .hasCamera, .hasNormalCamera, .hasTelephotoCamera variables.

@devicekit-danger-bot
Copy link

devicekit-danger-bot commented May 27, 2019

4 Warnings
⚠️ Plist changed, don’t forget to localize your plist values
⚠️ Source/Device.generated.swift#L618 - Prefer non-optional booleans over optional booleans.
⚠️ Source/Device.generated.swift#L620 - TODOs should be resolved (Longterm we need a better solu…).
⚠️ Source/Device.generated.swift#L1191 - Prefer empty collection over optional collection.

SwiftLint found issues

Warnings

File Line Reason
Device.generated.swift 618 Prefer non-optional booleans over optional booleans.
Device.generated.swift 1191 Prefer empty collection over optional collection.
Device.generated.swift 620 TODOs should be resolved (Longterm we need a better solu...).

Generated by 🚫 Danger

@Zandor300
Copy link
Member Author

@denisenepraunig Fixed the error and warning from Danger so now is ready to be merged.

@denisenepraunig
Copy link
Collaborator

Yay thanks!

@denisenepraunig denisenepraunig merged commit f83399f into master May 31, 2019
@Zandor300 Zandor300 deleted the telephoto-camera branch June 3, 2019 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: Check if device supports Telephoto Camera
3 participants