Wireless charger #209
Merged
Wireless charger #209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added the allMiniDevices and allSimulatorMiniDevices arrays for iPad mini
SwiftLint found issuesWarnings
Generated by 🚫 Danger |
Zandor300
requested changes
Oct 1, 2019
|
Sorry @Zandor300, what do you mean by that? |
|
@gianpispi You added a property to the initializer of the gyb Device class. Now you also need to add this boolean for every device that is in there so that the |
|
Okay got it! Now I think it's all right. Thanks for helping ;) |
Zandor300
requested changes
Oct 2, 2019
Zandor300
approved these changes
Oct 2, 2019
denisenepraunig
approved these changes
Oct 5, 2019
There was a problem hiding this comment.
Thank you @gianpispi - really cool feature! Thanks @Zandor300 for the review!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added wireless charging capability variable
Closes #201